[UTXO][BTCV] Add Bitcoin Vault cryptocurrency#259
[UTXO][BTCV] Add Bitcoin Vault cryptocurrency#259rrozek555 wants to merge 2 commits intoEdgeApp:masterfrom
Conversation
thehobbit85
left a comment
thehobbit85
left a comment
There was a problem hiding this comment.
Just a minor fix, other then that, it looks good
| symbolImage: `${imageServerUrl}/bitcoinvault-logo-solo-64.png`, | ||
| symbolImageDarkMono: `${imageServerUrl}/bitcoinvault-logo-solo-64.png` |
There was a problem hiding this comment.
No need for this anymore, we now just use 'currencyCode'.png as the symbol's file path.
There was a problem hiding this comment.
Hi @thehobbit85, i feel it is already fixed in my second commit in this PR :)
thank you for your review
There was a problem hiding this comment.
Sorry for not noticing that.
We do have a convention that you don't submit a commit that "fixes" a previous commit.
If you want you can read more about it under the "git" section in our conventions repo:
https://github.com/EdgeApp/edge-conventions/blob/master/README.md
For now though, if you could just squash the PR to only have 1 working commit that would great.
2 participants
Hello!
We would like to add BTCV (Bitcoin Vault) cryptocurrency to your wallet app.
Related PR to edge-react-gui: EdgeApp/edge-react-gui#2733