Skip to content

flysky st16 touchscreen modification support documents - #7527

Closed
SakuraHlh wants to merge 2 commits into
EdgeTX:mainfrom
SakuraHlh:flysky-st16-touch-support
Closed

flysky st16 touchscreen modification support documents#7527
SakuraHlh wants to merge 2 commits into
EdgeTX:mainfrom
SakuraHlh:flysky-st16-touch-support

Conversation

@SakuraHlh

@SakuraHlh SakuraHlh commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

Modification-related documents

Summary by CodeRabbit

  • New Features

    • Added support information for Flysky ST16 touch hardware, including setup and assembly guidance.
    • Added the new hardware mod to the documentation navigation.
  • Bug Fixes

    • Improved touch input handling on the ST16 so touch events now rely on actual hardware signals.
    • Added proper touch controller initialization and reset behavior for more reliable operation.

@coderabbitai

coderabbitai Bot commented Jul 4, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 128263db-94bd-42a5-a7e1-6cab173a0adb

📥 Commits

Reviewing files that changed from the base of the PR and between f503b11 and 218d7f9.

⛔ Files ignored due to path filters (16)
  • docs/assets/images/hw/flysky-st16/Back_of_st16.png is excluded by !**/*.png
  • docs/assets/images/hw/flysky-st16/Contact_connection.png is excluded by !**/*.png
  • docs/assets/images/hw/flysky-st16/FPC.png is excluded by !**/*.png
  • docs/assets/images/hw/flysky-st16/FPC_connection.png is excluded by !**/*.png
  • docs/assets/images/hw/flysky-st16/FPC_connector_module.png is excluded by !**/*.png
  • docs/assets/images/hw/flysky-st16/Install_the_TPU_gasket.png is excluded by !**/*.png
  • docs/assets/images/hw/flysky-st16/PCB.png is excluded by !**/*.png
  • docs/assets/images/hw/flysky-st16/Placement_of_FPC.png is excluded by !**/*.png
  • docs/assets/images/hw/flysky-st16/Screen_assembly_components.png is excluded by !**/*.png
  • docs/assets/images/hw/flysky-st16/Screen_installation.png is excluded by !**/*.png
  • docs/assets/images/hw/flysky-st16/Screen_separation.png is excluded by !**/*.png
  • docs/assets/images/hw/flysky-st16/Top_cover_installation.png is excluded by !**/*.png
  • docs/assets/images/hw/flysky-st16/Touching_glass_installation.png is excluded by !**/*.png
  • docs/assets/images/hw/flysky-st16/Touching_the_glass_treatment.png is excluded by !**/*.png
  • docs/assets/images/hw/flysky-st16/Touching_the_glass_treatment_2.png is excluded by !**/*.png
  • docs/assets/images/hw/flysky-st16/Wire_connection.png is excluded by !**/*.png
📒 Files selected for processing (4)
  • docs/mods/flysky-st16-touch-support.md
  • mkdocs.yml
  • radio/src/targets/st16/hal.h
  • radio/src/targets/st16/touch_driver.cpp

📝 Walkthrough

Walkthrough

Adds hardware GPIO/EXTI touch macros for the ST16 target, implements real touch driver functions (EXTI ISR, GPIO config, I2C reset) replacing stubs, removes forced-true touch event overrides, and adds documentation plus mkdocs navigation for a Flysky ST16 touch hardware mod.

Changes

Touch Support Implementation

Layer / File(s) Summary
Touch GPIO/EXTI hardware definitions
radio/src/targets/st16/hal.h
Adds INT/RST pin assignments and EXTI line/port/syscfg mapping macros, with conditional IRQ priority definition.
Touch driver implementation and event fixes
radio/src/targets/st16/touch_driver.cpp
Implements real EXTI ISR, GPIO config, I2C init, and reset pulse timing; removes forced-true overrides in ft6236 and cst836u touch-event checks.
Hardware mod documentation and nav entry
docs/mods/flysky-st16-touch-support.md, mkdocs.yml
Adds a step-by-step touch mod guide (wiring, screen replacement, pin mapping, assembly) and registers it in mkdocs navigation.

Estimated code review effort: 2 (Simple) | ~15 minutes

Sequence Diagram(s)

sequenceDiagram
  participant INTPin
  participant _touch_exti_isr
  participant touchEventOccured
  participant ft6236HasTouchEvent

  INTPin->>_touch_exti_isr: EXTI interrupt triggered
  _touch_exti_isr->>touchEventOccured: set flag
  ft6236HasTouchEvent->>touchEventOccured: read flag
  ft6236HasTouchEvent-->>ft6236HasTouchEvent: return flag state
Loading

Related Issues: None specified.

Related PRs: None specified.

Suggested labels: documentation, hardware, ST16

Suggested reviewers: None specified.

A touchscreen for the ST16, wired with care,
Interrupts now real, no fake flags to spare.
Docs guide the hands through glass and FPC,
GND to VCC, six pins set free.
The rabbit hops on, touch enabled with glee. 🐇✨

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@SakuraHlh SakuraHlh closed this Jul 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant