feat(tf-security): implement secret store with OS keyring backend#13
Merged
EdouardZemb merged 3 commits intomainfrom Feb 5, 2026
Merged
feat(tf-security): implement secret store with OS keyring backend#13EdouardZemb merged 3 commits intomainfrom
EdouardZemb merged 3 commits intomainfrom
Conversation
Add tf-security crate providing secure secret management: - SecretStore trait for credential abstraction - KeyringSecretStore using OS-native keyring (Linux/macOS/Windows) - SecretError with actionable user hints (no secret values exposed) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Story status: review → done - Sprint status synced - All 30 tests pass (unit + integration + doc-tests) - Code review validated all 3 acceptance criteria Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
The keyring crate with sync-secret-service feature requires dbus library headers to compile on Linux. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tf-securitycrate for secure secret management via OS keyringChanges
New crate:
tf-securitySecretStoreAPI:store_secret,get_secret,delete_secret,has_secret,try_has_secretSecretErrorenum with actionable hints (no secret values exposed)Debugimpl that never leaks secretsCI Updates
rust-testsjob (clippy + unit tests)rust-keyring-testsjob (integration tests with gnome-keyring)Acceptance Criteria
Test plan
cargo clippy --workspaceclean🤖 Generated with Claude Code