Revert "fix(ai-review): default opus-model to the bare "opus" alias" - #48
Merged
Hicham Zinalabdin (hichamza) merged 1 commit intoAug 12, 2026
Merged
Conversation
Hicham Zinalabdin (hichamza)
requested review from
Hussam Aldarwish (eduly-haldarwish)
and removed request for
a team
August 12, 2026 04:02
Hicham Zinalabdin (hichamza)
deleted the
revert-ai-review-opus-model-alias
branch
August 12, 2026 04:03
✅ ai-qa: PASSMerge commit
Posted by |
There was a problem hiding this comment.
✅ PASS
0 P2 / 1 P3 finding(s) noted — non-blocking.
Confidence: 100 · Merge risk: low
P0: 0 · P1: 0 · P2: 0 · P3: 1
P0 — Blockers
None.
P1 — Should Fix
None.
P2 — Nice-to-Have
None.
P3 — Nits
- PR title
Revert "fix(ai-review): default opus-model to the bare "opus" alias"doesn't carry a Conventional Commits type prefix (manifest flagstitle_ok: false). This is the standard git-generated revert title, and no commitlint/title-lint job exists in.github/workflows/(checked: actionlint, ai-qa-selftest, parity, selftest, unit, zizmor), so nothing in CI actually enforces this — noted only because the rubric surfaces it.
Strengths
- Exact, complete revert. Diffed this PR's change (
60a91e6..2bc9e67) against PR #47's own change (1035181..d000920) and confirmed they are the precise line-for-line inverse across all three touched spots: the README input table row, theaction.ymlinput'sdefault:, and the shell routing step's${OPUS:-...}fallback. Nothing extra, nothing missing. - No orphaned references left behind. Repo-wide grep for
opus-model/OPUS:-opus/ the bare-alias default found only the two changed files plus two docs (docs/adr/0003-...md,docs/plan.md) that discuss routing behavior in prose without citing the specific default string — neither needs updating for this revert to be internally consistent. - No blast radius beyond the default itself. No consumer workflow in this repo sets
opus-modelexplicitly, so the revert only changes what a caller gets when it omits the input — no call site breaks. - Test-quality claim holds up structurally, even though it can't be executed here: grepping
ai-review/lib/*.test.jsforclaude-opus-5/opus-modelturns up nothing, consistent with the PR's "unaffected; these two lines aren't covered by unit tests" note. This is a pure composite-action-wiring/docs change with no unit-testable logic, so no missing-tests penalty applies.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #47.
Summary
opus-model's default to the pinnedclaude-opus-5in both the action input default and the routing step's shell fallback, and reverts the matching README table entry.Test plan
node --test lib/*.test.js— 145/145 passing✅ ai-qa: PASS
Deploy health: healthy · findings P0 0 · P1 0 · P2 0 · P3 0
Last updated by ai-qa · QA run
🤖 AI Review — checklist verification
node --test lib/*.test.js— 145/145 passing — Test execution is out of scope for this review session (no toolchain access; test_execution reported as skipped). Grepped ai-review/lib/*.test.js forclaude-opus-5andopus-model— no matches, confirming the two changed lines aren't covered by these tests, which supports the 'unaffected' framing. The raw 145/145 pass count itself could not be independently reproduced without running the suite.Verification evidence:
git rev-parse HEAD~1 HEAD→ 60a91e6 / 2bc9e67 — exactly matches manifest.json's base_sha/head_shagit diff 60a91e6..2bc9e67 -- ai-review/README.md ai-review/action.yml (compared against PR #47's own diff: git diff 1035181..d000920 -- .)→ PR Revert "fix(ai-review): default opus-model to the bare "opus" alias" #48's 3 hunks are the exact line-for-line inverse of PR fix(ai-review): default opus-model to the bare "opus" alias #47's 3 hunks (README table cell, action.yml input default, shell fallback${OPUS:-...}) — no additional or missing changesGrep 'opus-model|OPUS:-opus|default.*opus' across the repository→ Only ai-review/action.yml, ai-review/README.md, docs/adr/0003-....md, and docs/plan.md match; the two docs files reference 'opus-model' only in prose about routing behavior, not the specific default string, so neither goes stale from this revertGrep 'opus-model' in .github/workflows/→ No matchesgrep 'claude-opus-5|opus-model' ai-review/lib/*.test.js→ No matchesLast updated by ai-review · verdict: pass.