Ir repeat code detection#206
Open
fletsche wants to merge 8 commits intoEdzelf:masterfrom
Open
Conversation
added 8 commits
December 21, 2018 17:00
|
Great idea! I was also puzzled that there was no function to hold the keys of traditional commands, especially the volume control. I have a remote control from an old GoldStar TV. I included your add-ons. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #205
I actually do not know whether Edzelf's original IR routine could also interpret other IR codes (non NEC style). I could not test that because I only have NEC style RCs.
My routine offers an addition to the config string for IR commands. If the commands are not modified repeat codes do not trigger additional commands. If you add a / XXX (where XXX is a integer value > 0) to the command this should result in a repetition of the command after XXX ms. However the repetition interval is restricted by the time it takes until scanir() gets called again, so very short repetition times are useless and might result in unpredictable intervals.
An example from my config:
I hope you find this useful too!