Station name "icy-name" is not always present in datastream#450
Open
dheydeck wants to merge 1 commit intoEdzelf:masterfrom
Open
Station name "icy-name" is not always present in datastream#450dheydeck wants to merge 1 commit intoEdzelf:masterfrom
dheydeck wants to merge 1 commit intoEdzelf:masterfrom
Conversation
Station name "icy-name" is not always present in datastream and, when it isn't, the previous station name appears as the prefix to the current track. This change nulls the station name prior to parsing the datastream and also suppresses the hyphen that separates the normal station name from the track name if it is absent.
dheydeck
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Station name "icy-name" is not always present in datastream and, when it isn't, the previous station name appears as the prefix to the current track. This change nulls the station name prior to parsing the datastream and also suppresses the hyphen that separates the normal station name from the track name if it is absent.
This my suggested solution to issue #445; I haven't programmed in C++ so this may not be an elegant piece of code and any improvement is welcome.