Skip to content

FEATURE: add optimization tracker#63

Open
yaylim wants to merge 6 commits into
Eelbrain:masterfrom
yaylim:optimization_tracker
Open

FEATURE: add optimization tracker#63
yaylim wants to merge 6 commits into
Eelbrain:masterfrom
yaylim:optimization_tracker

Conversation

@yaylim

@yaylim yaylim commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator

Addresses issue #62. This PR adds an optional track_progress argument to NCRF.fit() and fit_ncrf() that records the internal optimization state at each iteration, allowing users to inspect how the model evolves during fitting.

@christianbrodbeck christianbrodbeck left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need a decorator for this as opposed to a normal argument? I am somewhat worried about the opaqueness of this (a hidden track_progress argument that does not appear in the method signature). This makes it harder to read and understand what's goin on.

@yaylim

yaylim commented Jun 17, 2026

Copy link
Copy Markdown
Collaborator Author

I wanted to write it as a decorator to separate the track_progress out of core fitting logic. I can refactor this to add track_progress=False and tracker=None as explicit arguments directly in the NCRF.fit() and fit_ncrf() signatures, and remove the decorator. Would that make it more understandable?

@christianbrodbeck

christianbrodbeck commented Jun 18, 2026 via email

Copy link
Copy Markdown
Member

@yaylim yaylim marked this pull request as draft June 26, 2026 18:27
@yaylim yaylim marked this pull request as ready for review June 26, 2026 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants