FEATURE: add optimization tracker#63
Open
yaylim wants to merge 6 commits into
Open
Conversation
christianbrodbeck
left a comment
Member
There was a problem hiding this comment.
Why do we need a decorator for this as opposed to a normal argument? I am somewhat worried about the opaqueness of this (a hidden track_progress argument that does not appear in the method signature). This makes it harder to read and understand what's goin on.
Collaborator
Author
|
I wanted to write it as a decorator to separate the |
Member
|
Yes I think that would make it easier to readOn Jun 17, 2026, at 2:25 PM, yaylim ***@***.***> wrote:yaylim left a comment (Eelbrain/neuro-currentRF#63)
I wanted to write it as a decorator to separate the track_progress out of core fitting logic. I can refactor this to add track_progress=False and tracker=None as explicit arguments directly in the NCRF.fit() and fit_ncrf() signatures, and remove the decorator. Would that make it more understandable?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because your review was requested.Message ID: ***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses issue #62. This PR adds an optional
track_progressargument toNCRF.fit()andfit_ncrf()that records the internal optimization state at each iteration, allowing users to inspect how the model evolves during fitting.