feat(rpc): Add parseOptions#2197
Open
patroza wants to merge 2 commits into
Open
Conversation
🦋 Changeset detectedLatest commit: 5929134 The changes in this PR will be included in the next version bump. This PR includes changesets to release 27 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
1a80774 to
76f6a5c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2124 RPC schema parsing in v4 was not configurable at the RPC boundary, forcing schema-level annotations for behaviors like concurrency. This change adds first-class parse concurrency support to both client and server so schema parsing concurrency can be controlled per RPC instance.
API surface
parseOptions?: Pick<AST.ParseOptions, "concurrency">to:RpcClient.make(...)RpcServer.make(...)layer,layerHttp,toHttpEffect,toHttpEffectWebsocket)Client-side wiring
parseOptionsbefore schema usage so only{ concurrency }is forwarded, even if extra properties are provided at runtime.Server-side wiring
parseOptionsbefore schema usage so only{ concurrency }is forwarded, even if extra properties are provided at runtime.Tests
onExcessProperty) and verifies only concurrency is effectively applied.Release note
Example usage: