Fix sqlite-do Durable Object transactions#2217
Open
dmmulroy wants to merge 8 commits into
Open
Conversation
🦋 Changeset detectedLatest commit: cf0b431 The changes in this PR will be included in the next version bump. This PR includes changesets to release 27 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Collaborator
|
It feels like there is a cleaner way of doing this. Will take a look when I have a moment to look at the cf docs. |
Author
|
happy to refactor or change the impl - anything in particular you want changed? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2216
Author: Pi (GPT 5.5 on high)
Guided by: Dillon Mulroy dillon@cloudflare.com
Changes
storage?: DurableObjectStorageinSqliteClientConfigwithTransactionthroughstorage.transaction(...)BEGIN/SAVEPOINTValidation
pnpm test packages/sql/sqlite-do/test/Client.test.ts— blocked:vitestnot installedpnpm lint-fix— blocked:oxlintnot installedpnpm check:tsgo— blocked: local tool/build-mode issue