fix(schema): preserve named-field decoded value on StructWithRest key overlap#2246
Closed
Leka74 wants to merge 1 commit into
Closed
fix(schema): preserve named-field decoded value on StructWithRest key overlap#2246Leka74 wants to merge 1 commit into
Leka74 wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: fc1cdb9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 27 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Closing in favor of #2312 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type
Description
When a
Schema.StructWithRestindex signature's key domain overlapped a named property signature, the index signature's decoded value overwrote the property signature's transformed value. The declared type narrowed via intersection but the runtime did not.The index signature still runs for overlapping keys, its refinement checks (e.g.
Schema.Finite) still apply and surface errors but its decoded value is no longer written when a property signature has already produced one.disclaimer: fix applied with Opus 4.7
Related