Align Workflow.make with Rpc style#2294
Open
mattiamanzati wants to merge 1 commit into
Open
Conversation
🦋 Changeset detectedLatest commit: ecd70f5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 27 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Bundle Size Analysis
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nameto_tag.namecreation option in favor ofWorkflow.make(name, opts).idempotencyKeyandsuspendedRetryScheduleon the public Workflow API.class MyWorkflow extends Workflow.make(...) {}.Validation
pnpm check:tsgopnpm test packages/effect/test/unstable/workflow/WorkflowEngine.test.tspnpm test packages/effect/test/unstable/workflow/DurableQueue.test.tspnpm test packages/effect/test/cluster/ClusterWorkflowEngine.test.tsNote: full
pnpm testwas attempted but did not complete due to unrelated SQL integration environment failures/timeouts.