🛡️ Sentinel: [CRITICAL] Fix Path Truncation Vulnerability in Model Validation#3509
🛡️ Sentinel: [CRITICAL] Fix Path Truncation Vulnerability in Model Validation#3509EffortlessSteven wants to merge 1 commit intomainfrom
Conversation
The `validate_model_request` function previously relied solely on string matching (like `.ends_with()`) to validate that file paths had safe extensions (`.gguf` or `.safetensors`). This approach is vulnerable to Path Truncation attacks (null byte injection) when dealing with underlying C/OS APIs, which treat null bytes as string terminators. An attacker could potentially bypass the extension validation by supplying a path like `malicious.txt\0.gguf`. This commit adds an explicit check to reject any `model_path` containing a null byte early in the validation process. A unit test (`test_model_path_null_byte_rejection`) has been added to ensure the correct behavior.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1 participant
🚨 Severity: CRITICAL
💡 Vulnerability: The
validate_model_requestfunction inSecurityValidatorused.ends_with()to validate file extensions. This was vulnerable to path truncation if the input contained a null byte (e.g.,model.txt\0.gguf).🎯 Impact: An attacker could bypass the file extension check by appending a null byte and a valid extension, allowing arbitrary files to be loaded or executed by underlying C APIs (like
llama.cpp) which use null-terminated strings.🔧 Fix: Added an explicit check to reject any
model_pathcontaining a null byte (\0) early in the validation logic.✅ Verification: Executed
cargo test -p bitnet-server --lib security::tests::test_model_path_null_byte_rejectionandcargo clippy -p bitnet-server -- -D warnings.PR created automatically by Jules for task 7369668885997979439 started by @EffortlessSteven