🛡️ Sentinel: [CRITICAL] Fix Path Truncation Vulnerability in Model Path Validation

[EffortlessSteven]

🚨 Severity

CRITICAL

💡 Vulnerability

The validate_model_request function in bitnet-server/src/security.rs did not validate if the provided model path contains null bytes (\0). When these paths are passed to underlying C libraries (like llama.cpp) or OS filesystem APIs, the string is truncated at the null byte. This allows attackers to bypass validation checks (e.g., extension checks like .gguf) by appending a null byte followed by the required extension, while the underlying system operates on the truncated path.

🎯 Impact

An attacker could bypass the model_path.ends_with(".gguf") validation by supplying a path like /etc/passwd\0.gguf. The validation logic in Rust sees a valid path ending in .gguf, but the underlying C/OS layer truncates it at the null byte, resulting in unauthorized file access to /etc/passwd.

🔧 Fix

Added a check in validate_model_request to explicitly reject any model path containing a null byte (\0), returning an InvalidFieldValue error. Also added a unit test test_model_path_null_byte_rejection to ensure this behavior is correct.

✅ Verification

1. Run cargo fmt --all
2. Run cargo clippy -p bitnet-server -- -D warnings
3. Run cargo test -p bitnet-server --lib security::tests::test_model_path_null_byte_rejection

---

PR created automatically by Jules for task 14837676839331371447 started by @EffortlessSteven

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.

[gemini-code-assist]

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

[coderabbitai]

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 8df19fa4-e8b1-4c8d-9a91-8df3e26bda90

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch sentinel/fix-path-truncation-14837676839331371447

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}