Skip to content

🎨 Palette: Add keyboard and screen reader accessibility to scrollable output containers#3525

Draft
EffortlessSteven wants to merge 2 commits intomainfrom
palette-fix-output-a11y-12068300566754683886
Draft

🎨 Palette: Add keyboard and screen reader accessibility to scrollable output containers#3525
EffortlessSteven wants to merge 2 commits intomainfrom
palette-fix-output-a11y-12068300566754683886

Conversation

@EffortlessSteven
Copy link
Copy Markdown
Member

💡 What: Replaced <label> with styled <div> for non-form control scrollable text regions and added tabindex="0", role="region", and aria-labelledby to them.
🎯 Why: Scrollable containers (e.g. ones with overflow-y: auto) need to be keyboard focusable so that keyboard-only users can scroll through the text output. Furthermore, associating a label explicitly makes them properly perceivable for screen readers. <label> tags should strictly be for form elements.
📸 Before/After: N/A - Visuals are effectively unchanged.
♿ Accessibility: Improved keyboard accessibility and screen reader support for the WASM browser demo output regions.


PR created automatically by Jules for task 12068300566754683886 started by @EffortlessSteven

… output containers

Replaced `<label>` elements incorrectly wrapping static output regions with explicitly styled `<div>` elements, while ensuring the underlying scrollable `<div class="output">` containers correctly implement `tabindex="0"`, `role="region"`, and `aria-labelledby` for screen reader readability and keyboard scrolling.
@google-labs-jules
Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@gemini-code-assist
Copy link
Copy Markdown

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 16, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: c1b9e3b5-c9da-4748-8172-fb05dd14a782

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch palette-fix-output-a11y-12068300566754683886

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Add disk space cleanup steps to `performance-tracking.yml` and `property-tests.yml` workflows and set `CARGO_PROFILE_TEST_DEBUG: "0"` in the global `env` blocks to resolve `No space left on device` errors in the `Cargo Tests (smoke)` jobs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant