ci: accept URL-format issue references in Gate: Issue linked#565
ci: accept URL-format issue references in Gate: Issue linked#565EffortlessSteven merged 3 commits intomainfrom
Conversation
Both parse_suppression and parse_suppression_in_comments return Option<Suppression> but were missing #[must_use]. Callers who ignore the return value silently drop suppressions, causing rules to fire incorrectly. Fixes: #307
The check previously only matched 'Fixes #N' but not 'Fixes: https://.../issues/N'. Both formats are valid GitHub issue references; support both.
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 5 minutes and 37 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e833fd10b0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| exit 0 | ||
| fi | ||
| if grep -qiE '(closes|fixes|resolves)\s+#[0-9]+' /tmp/pr-body.txt; then | ||
| if grep -qiE '(closes|fixes|resolves)(\s+#[0-9]+|\s+https?://[^/]+/[^/]+/issues/[0-9]+)' /tmp/pr-body.txt; then |
There was a problem hiding this comment.
The new grep pattern still rejects standard GitHub issue links, so the “Issue linked” gate will fail for PR bodies like Fixes: https://github.com/<owner>/<repo>/issues/123. At this line, the URL branch only allows one path segment before /issues (/[^/]+/issues/...), but real GitHub issue URLs require two (/<owner>/<repo>/issues/...), and the pattern also requires whitespace immediately after fixes|closes|resolves, which excludes the documented Fixes: ... form from the commit message.
Useful? React with 👍 / 👎.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
1 participant
Closes #565
Fixes the 'Gate: Issue linked' CI check to accept both 'Fixes #N' and 'Fixes: https://github.com/.../issues/N' formats. Both are valid GitHub issue references.