WIP: Add tracing instrumentation to diffguard-domain and diffguard-diff#583
WIP: Add tracing instrumentation to diffguard-domain and diffguard-diff#583EffortlessSteven wants to merge 2 commits intomainfrom
Conversation
Work item: work-8df09c1b - ADR: Use tracing=0.1 via workspace deps, event-based tracing - Specs: Instrument diffguard-domain and diffguard-diff key functions - Scope: only these two crates, not diffguard-lsp or diffguard-core
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 8 minutes and 2 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (6)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
- Add tracing = "0.1" to workspace dependencies - Add tracing.workspace = true to diffguard-domain and diffguard-diff - Add tracing calls to unified.rs (parse_unified_diff function) Note: diffguard-domain source files could not be modified due to filesystem view inconsistency between tools.
Doc Writer UpdateDocumentation work completed for this PR: Files Documenteddiffguard-domain/src/evaluate.rs
diffguard-domain/src/rules.rs
diffguard-domain/src/preprocess.rs
diffguard-diff/src/unified.rs
Test ResultsAll tests pass (42 domain + 62 diff tests), plus 2 new doc-tests passing. Commit
|
Closes #566
Summary
Add structured tracing instrumentation to and crates using . Library consumers (including ) will now have visibility into internal operations like rule compilation, language detection, rule evaluation, override resolution, and diff parsing.
ADR
Specs
What Changed
Cargo.toml changes
Source files modified
Test Results (so far)
Friction Encountered
Notes