Skip to content

🎨 Palette: Enhanced CLI UX and fixed accessibility crash#59

Open
EiJackGH wants to merge 2 commits intomainfrom
palette-ux-improvements-15874837156841492643
Open

🎨 Palette: Enhanced CLI UX and fixed accessibility crash#59
EiJackGH wants to merge 2 commits intomainfrom
palette-ux-improvements-15874837156841492643

Conversation

@EiJackGH
Copy link
Owner

💡 What:

  • Refactored Colors class to fix a crash when using --no-color and remove duplicate code.
  • Added input validation for CLI arguments (days, cash, price) with friendly error messages.
  • Enhanced the final simulation report with ROI %, Total Trades count, and ASCII box formatting.
  • Fixed a bug where the 'Daily Trading Ledger' header was printed twice.

🎯 Why:

  • Users need to be able to run the tool without colors for accessibility or logging purposes (--no-color was broken).
  • Users need to know if they provide invalid inputs (e.g. negative days) instead of seeing a stack trace.
  • The final report lacked key metrics like ROI and trade volume, which are essential for evaluating a trading strategy.

📸 Before/After:
Before:

  • Crash on --no-color.
  • Double header print.
  • Basic text output.

After:

  • Clean, crash-free execution with --no-color.
  • Single, conditional header.
  • Rich, boxed final report with ROI and trade stats.

♿ Accessibility:

  • Fixed the --no-color flag to correctly disable ANSI codes.

PR created automatically by Jules for task 15874837156841492643 started by @EiJackGH

…n, and enhance final report formatting with ROI/stats.

Co-authored-by: EiJackGH <172181576+EiJackGH@users.noreply.github.com>
@google-labs-jules
Copy link
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

…s to CLI.

Co-authored-by: EiJackGH <172181576+EiJackGH@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant