Skip to content

Added files for Pull request template#31

Closed
Adez017 wants to merge 7 commits into
EkaAI-Tech:masterfrom
Adez017:master
Closed

Added files for Pull request template#31
Adez017 wants to merge 7 commits into
EkaAI-Tech:masterfrom
Adez017:master

Conversation

@Adez017

@Adez017 Adez017 commented Jul 29, 2025

Copy link
Copy Markdown
Contributor

Closes #27 . please take a look around @thedevyashsaini @sapatevaibhav

@Adez017

Adez017 commented Jul 29, 2025

Copy link
Copy Markdown
Contributor Author

hi @sapatevaibhav @thedevyashsaini , by mistake i had linked the #28 also to this pull request , please consider this two also .
also @thedevyashsaini, there can be some tweaks in the code as i am not regular practitioner for typescript part , please verify first
before moving forward

@Adez017

Adez017 commented Jul 30, 2025

Copy link
Copy Markdown
Contributor Author

CC: @thedevyashsaini @sapatevaibhav

@thedevyashsaini

Copy link
Copy Markdown

Why are there changes in 7 files?

@Adez017

Adez017 commented Jul 31, 2025

Copy link
Copy Markdown
Contributor Author

Why are there changes in 7 files?

As i had added the code for #28 in the same PR by Mistake

@Adez017

Adez017 commented Aug 1, 2025

Copy link
Copy Markdown
Contributor Author

if every thing looks good we can move forward @thedevyashsaini

@sapatevaibhav

Copy link
Copy Markdown
Collaborator

@Adez017 Can you change the description of this PR with some information regarding the changes, as well will recommend to separate the pull request template as GSSoC distributes scores upon MR's.
as well keep eye on #25

@Adez017

Adez017 commented Aug 2, 2025

Copy link
Copy Markdown
Contributor Author

@Adez017 Can you change the description of this PR with some information regarding the changes, as well will recommend to separate the pull request template as GSSoC distributes scores upon MR's. as well keep eye on #25

Hi @sapatevaibhav , i had added the template which ask to describe the PR , like which issue does it close , why are we need this changes , what changes included . are this changes tested ? any other notes .

@Adez017

Adez017 commented Aug 2, 2025

Copy link
Copy Markdown
Contributor Author

as well will recommend to separate the pull request template as GSSoC distributes scores upon MR's.
could you please elaborate it

@Adez017 Adez017 changed the title Create pull_request_template.md Added files for Pull request template Aug 5, 2025
@Adez017

Adez017 commented Aug 9, 2025

Copy link
Copy Markdown
Contributor Author

Hi @sapatevaibhav , i think its ready . please have a look

@itspsychocoder itspsychocoder left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned, you have also merged #28, but your useFastSudo.ts hook file is empty and also you are importing sudo.rs in main file and using functions which are not implemented as your sudo.rs is empty.

Comment thread src-tauri/src/sudo.rs
Comment thread src/hooks/useFastSudo.ts
Comment thread src-tauri/src/main.rs
@Adez017

Adez017 commented Aug 29, 2025

Copy link
Copy Markdown
Contributor Author

@itspsychocoder i had pushed some changes take a look

@Adez017 Adez017 closed this Feb 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create Pull Request Template

4 participants