fix esbuild if srcDir is different from the default#217
Open
douglasward wants to merge 1 commit intoElderjs:masterfrom
Open
fix esbuild if srcDir is different from the default#217douglasward wants to merge 1 commit intoElderjs:masterfrom
douglasward wants to merge 1 commit intoElderjs:masterfrom
Conversation
nickreese
approved these changes
Nov 12, 2021
Contributor
nickreese
left a comment
nickreese
left a comment
There was a problem hiding this comment.
Looks good to me. Sorry for the delay. International moves are a bit of chaos and take a while to unwind.
| // abs path first | ||
| if (nameFixed.includes(rootDirFixed)) { | ||
| const rel = windowsPathFix(path.relative(path.join(rootDirFixed, 'src'), name)) | ||
| const rel = windowsPathFix(path.relative(path.join(rootDirFixed, srcDir.replace(rootDir, '')), name)) |
Contributor
There was a problem hiding this comment.
For some reason I'm having a brain fart here. Can you confirm there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the
srcDirin theelder.config.jsis set to something other thansrc, then esbuild no longer works correctly. This pull request aims to fix this.Everything seems to work fine (including hydration) except that the
onMountsvelte hook isn't called for the demo clock component and I can't work out why.