Skip to content

remove module and rootDir from the compilerOptions#27

Merged
nickreese merged 1 commit intoElderjs:masterfrom
nirjan-dev:update-sample-tsconfig
Nov 2, 2020
Merged

remove module and rootDir from the compilerOptions#27
nickreese merged 1 commit intoElderjs:masterfrom
nirjan-dev:update-sample-tsconfig

Conversation

@nirjan-dev
Copy link
Contributor

  • Fixes typescript issue while using another svelte component from npm
  • Fixes an issue with prop exports in svelte files that use typescript
  • related issue

@nickreese
Copy link
Contributor

@NK-WebDev I know @thisislawatts is working on a typescript change as well. Will these conflict? Elderjs/elderjs#72

@nirjan-dev
Copy link
Contributor Author

@nickreese He hasn't changed this file in his commits so far but I don't know if he plans to change it latter or if these config values will need to be changed after merging his changes, so for now I can include a link to this PR on the PR for the docs (for ts info). Then We can change the docs later if the typescript setup process changes.

@nickreese nickreese merged commit db45d1c into Elderjs:master Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants