HF: Replace bip34 with simpler equivalent #251
HF: Replace bip34 with simpler equivalent #251jtimon wants to merge 3 commits intoElementsProject:elements-0.14.1from
Conversation
|
concept ACK, will review |
|
At least with Bitcoin, height-based locktime must be greater than the current height, so setting this to equal should be invalid? For BitcoinHardfork/bitcoin#3, I set locktime=height-1 because of this. |
|
Summary of extra-Github discussion:
|
4f799c6 to
fd670af
Compare
|
Rebased, squashed, hopefully fixed nits. |
fd670af to
b1f09f7
Compare
|
Rebased on top of #276 and made a little bit more like https://github.com/BitcoinHardfork/bitcoin/pull/3/files as suggested by @luke-jr to reduce rebase disruption, no longer removing bip30 not bip34Height. |
|
Closing due to lack of activity and since we've launched Liquid without this change. Porting to master with backwards compatibility(in chain sense) still could work. |
The height is mandatory in the coinbase's nLockTime instead of in its script.
The miner still puts it in the script.
The new rule is active from the beginning instead of a given height, thus there's no need to implement bip30, which is removed.