Skip to content

"Fix #10: Unify settings system with reusable component"#12

Open
Dheemanth07 wants to merge 1 commit intoElijahFeldman7:masterfrom
Dheemanth07:fix/unify-settings-component
Open

"Fix #10: Unify settings system with reusable component"#12
Dheemanth07 wants to merge 1 commit intoElijahFeldman7:masterfrom
Dheemanth07:fix/unify-settings-component

Conversation

@Dheemanth07
Copy link
Copy Markdown

Summary

This PR solves issue #10 by implementing a reusable Settings component and applying it across all main pages to ensure UI consistency.

Key Changes

  • Created src/components/Settings.js: Having global settings UI and toggle logic.
  • Refactored Pages: Updated DailyScheduler, FocusTimer, HabitTracker, TaskManager, KnowledgeBase, and QuickLinks to use the new component.
  • Fixed UI/UX:
    • The "Settings" gear is now fixed to the top-right of the screen on all pages.
  • Renamed Title: Changed the menu header to "Settings" to clearly distinguish it from page-specific controls (like the timer duration).

Notes for Reviewers

  • Placeholders: The menu items (Display, Account, Log Out) are currently set to # (placeholders). I established the structure so these can be easily linked to real routes or authentication logic in a future update.
  • Local vs. Global: I verified that the local settings (e.g., inside the Focus Timer card) function independently of this new global menu.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant