Minimap map icon size (blips) slider + free move magnet snapping - #1115
Open
labrie75 wants to merge 5 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds three minimap features plus a profile-switch fix:
1. Map Icon Size (Blips) slider (Display > Minimap, below Size; 0.5-3.0, default 1.0)
Tracking blips (herbs, ore, quest dots) are engine-drawn textures that cannot be resized individually, so at large map sizes they get hard to read. This scales the whole Minimap while dividing its frame size, keeping the on-screen map at exactly
mapSize-- only the blips change size. Everything else is compensated:Also raises the map Size slider cap from 600 to 1000 -- on ultrawide monitors there is room to run the minimap much larger than 600, and blips were the readability blocker at large sizes.
2. Free Move magnet snapping
While Shift-dragging a button (Free Move Buttons), it now snaps flush to nearby free-moved buttons (stack above/below/beside, plus edge/center alignment) and to the minimap border -- inside or outside face on square shapes; on circle shapes the button snaps onto the rim along its current angle. Hold Ctrl together with Shift while dragging to disable snapping for pixel-precise placement. The Free Move Buttons tooltip is updated to mention this.
3. Circle-shape polish: with a circle map shape --
Everything follows the Shape setting automatically; square shapes are unchanged. Note that switching between square and circle re-lays out the button row, so buttons the user had free-moved to custom positions may need repositioning after a shape switch. Corner-pinned buttons (Omnium Folio, corner Mail) are left as-is since they have their own position offsets.
At the default blip scale (1.0) and without dragging, every code path computes exactly what it did before -- no change for existing users.
4. Profile switching re-applies minimap settings:
RefreshAllAddonsonly called the minimap's flyout refresher, so switching profiles (or presets) left the minimap on the outgoing profile's size/shape until a reload -- the new per-profile blip scale hit the same gap. Added the module's own_EMM_ApplyMinimapbridge call next to the existing flyout one, matching how the other modules are refreshed there (_ERB_Apply,_EDB_Apply, ...). One line inEllesmereUI_Profiles.lua.Includes the koKR locale entries for the new option, its tooltip, and the updated Free Move tooltip. No
_keys.txtupdate is needed -- this PR adds no explicitL()literals (the new option label/tooltip localize through the widget auto-translation path like the existing minimap options).How was it tested?
Tested in game on live retail: blip scales 0.5-3.0 at map sizes 140-1000, square and circle shapes, with clock/location/coords/FPS enabled, addon buttons grouped and ungrouped, Omnium Folio visible, and profile swaps. Verified while gathering that herb/ore nodes and other tracked blips stay at their correct map positions after scaling -- only their size changes. Profile switching verified with different blip scales and map sizes saved per profile (and via preset/profile keybind swaps): the minimap now follows the incoming profile immediately instead of needing a reload. Magnet verified against buttons and all four map edges (both faces), with the Ctrl+Shift bypass. Files parse clean, no load errors.
Screenshots
Same map size, blip scale 1.0 / 1.5 / 2.0 -- the map footprint and all UI elements stay identical; only the blips grow:
Circle shape: the button row follows the rim, and backgrounds/icons render round automatically:
Checklist
P.S. The motivation: while herb/ore farming I run a large minimap, but the tracking blips stay tiny regardless of map size, so nodes are easy to miss at a glance. This slider lets the blips grow to match how large you run the map.