Use health bar border size for cast bars - #1143
Open
DoGi114 wants to merge 1 commit into
Open
Conversation
Make borders of the castbars inherit the bordersize from the parent frame
Author
|
@EllesmereGaming |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use health bar border size for cast bars
What does this PR do?
Makes unit-frame cast bars use the configured health-bar border size instead of a hard-coded value.
The existing default of 1 is retained when no border size is configured.
How was it tested?
Tested on my local branch with the stable version of the game ( _retail )
Screenshots
Checklist
Hard to make it OFF by default since its just inheritance ( which in my opinion should work like that from the begining.
HookScript/hooksecurefunconly, neverSetScripton Blizzard frames