Skip to content

Use health bar border size for cast bars - #1143

Open
DoGi114 wants to merge 1 commit into
EllesmereGaming:mainfrom
DoGi114:unitframes-castbar-border-size
Open

Use health bar border size for cast bars#1143
DoGi114 wants to merge 1 commit into
EllesmereGaming:mainfrom
DoGi114:unitframes-castbar-border-size

Conversation

@DoGi114

@DoGi114 DoGi114 commented Aug 2, 2026

Copy link
Copy Markdown

Use health bar border size for cast bars

What does this PR do?

Makes unit-frame cast bars use the configured health-bar border size instead of a hard-coded value.

The existing default of 1 is retained when no border size is configured.

How was it tested?

Tested on my local branch with the stable version of the game ( _retail )

Screenshots

image

Checklist

  • New settings default OFF (no behavior change without opt-in)
    Hard to make it OFF by default since its just inheritance ( which in my opinion should work like that from the begining.
  • Zero cost while disabled: no events registered, no polling, no hooks doing work, no frames built
  • Cheap while enabled: event-driven (no polling, no timer-based logic, no per-frame allocations)
  • No writes onto Blizzard-owned frames (weak-table pattern used); HookScript/hooksecurefunc only, never SetScript on Blizzard frames
  • Tested in-game, works on live retail; no load errors on the 12.1 PTR client

Make borders of the castbars inherit the bordersize from the parent frame
@DoGi114 DoGi114 changed the title Update EllesmereUIUnitFrames.lua Use health bar border size for cast bars Aug 2, 2026
@DoGi114

DoGi114 commented Aug 2, 2026

Copy link
Copy Markdown
Author

@EllesmereGaming
Hi! When you have a chance, could you review this small cast-bar border-size change? It makes the cast bar use the unit frame’s configured borderSize instead of a hard-coded value. Thanks!
Hope to see it in the next release <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant