QoL: add mailbox improvements -- return shortcut and richer hover text - #1156
Open
Absol3m wants to merge 1 commit into
Open
QoL: add mailbox improvements -- return shortcut and richer hover text#1156Absol3m wants to merge 1 commit into
Absol3m wants to merge 1 commit into
Conversation
Ctrl-click an inbox row to return that mail to its sender. Hovering a row now lists every attachment once the mail carries more than one, and spells out a subject too long for the row to display. Deliberately no shift-click take-contents shortcut: the retail client already does this natively. Running our own take on top of it fired the operation twice, which the server answers with an internal mail database error and which leaves an emptied item mail undeleted. Nothing is hooked until the feature is switched on: left off, it costs one frame and one PLAYER_LOGIN. Once on, the mailbox events install the row hooks on the next visit (or immediately, if it is switched on while standing at a mailbox) and are then dropped, because hooks are permanent and the handlers gate themselves on the setting from that point. Every hook is additive, so the default click and the default tooltip still run, and no Blizzard frame is written to. Attachment slots are not guaranteed contiguous, so the tooltip walks every slot rather than stopping once it has seen as many items as the header reports. Off by default. Its individual parts sit in a cog popup on the master toggle, so the section stays one row tall however many parts it gains -- the section is named for improvements rather than shortcuts because it is meant to house the mailbox work that follows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a Mailbox Improvements section to the Quality of Life page, off by default.
Each part can be switched off individually from a cog on the master toggle. The section is named for improvements rather than shortcuts because it is meant to house the mailbox work that follows.
Deliberately no shift-click take-contents shortcut: the retail client already does this natively. An earlier revision added one and it fired the take twice — the server answers with an internal mail database error, and an emptied item mail is left undeleted. This is recorded in the file header so it does not get reintroduced.
How was it tested?
Live retail, real mailbox:
Not tested on the 12.1 PTR client.
Checklist
HookScriptonly, neverSetScript-- the default click and tooltip always still run