Skip to content

feat(mythicplus): add the Mythic+ Tools module #1238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wanghwplus wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(mythicplus): add the Mythic+ Tools module #1238

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .pkgmeta
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ move-folders:
EllesmereUI/EllesmereUIDataBars: EllesmereUIDataBars
EllesmereUI/EllesmereUIFriends: EllesmereUIFriends
EllesmereUI/EllesmereUIMinimap: EllesmereUIMinimap
EllesmereUI/EllesmereUIMythicPlus: EllesmereUIMythicPlus
EllesmereUI/EllesmereUIMythicTimer: EllesmereUIMythicTimer
EllesmereUI/EllesmereUINameplates: EllesmereUINameplates
EllesmereUI/EllesmereUIQoL: EllesmereUIQoL
Expand Down
4 changes: 4 additions & 0 deletions EUI_UnlockMode.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -626,6 +626,10 @@ EllesmereUI._ELEMENT_SETTINGS_MAP = {
-- Mythic+ Timer
["EMT_MythicTimer"] = { module = "EllesmereUIMythicTimer", page = "Mythic+ Timer", sectionName = "DISPLAY", highlightText = "Scale" },

-- Mythic+ keystone displays
["EMP_KeystoneList"] = { module = "EllesmereUIMythicPlus", page = "Keystones", sectionName = "PARTY KEYSTONES", highlightText = "Show Party Keystones" },
["EMP_KeystoneBanner"] = { module = "EllesmereUIMythicPlus", page = "Keystones", sectionName = "KEYSTONE OWNERS", highlightText = "Show Keystone Owners" },

-- Dragon Riding HUD (Blizz UI Enhanced > Dragon Riding page)
["EDR_Cluster"] = { module = "EllesmereUIBlizzardSkin", page = "Dragon Riding", sectionName = "GENERAL", highlightText = "Enable Dragon Riding Bar" },

Expand Down
42 changes: 42 additions & 0 deletions EUI__General_Options.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -519,6 +519,46 @@ end
-- EllesmereUI:NavigateToElementSettings(module, page, section, preSelect, highlight).
-------------------------------------------------------------------------------
EllesmereUI._WHATSNEW_PATCHES = {
{
version = "8.7.7",
heroes = {
{
-- New module. The hero opens the module's first page rather
-- than a control: nothing here is a single setting, and the
-- master switch is the first row that page builds anyway.
module = "Mythic+ Tools",
title = "New Module",
desc = "A Mythic+ companion for the Group Finder: dungeon score and best key drawn onto each dungeon icon, click-to-teleport on the icons themselves, a docked panel listing this week's and the season's runs, plus floating displays for your party's keystones.",
nav = { module = "EllesmereUIMythicPlus", page = "Dungeon Icons", section = "GENERAL", highlight = "Enable Mythic+" },
},
},
features = {
{
module = "Mythic+ Tools",
title = "Score Overlay",
desc = "Best key level and season score on every dungeon icon",
nav = { module = "EllesmereUIMythicPlus", page = "Dungeon Icons", section = "SCORE OVERLAY", highlight = "Show Score Overlay" },
},
{
module = "Mythic+ Tools",
title = "Dungeon Teleports",
desc = "Click a dungeon icon to cast its teleport, with an optional party announce",
nav = { module = "EllesmereUIMythicPlus", page = "Dungeon Icons", section = "TELEPORTS", highlight = "Teleport Buttons" },
},
{
module = "Mythic+ Tools",
title = "Weekly Panel",
desc = "This week's runs beside the Group Finder; hold Shift for season best",
nav = { module = "EllesmereUIMythicPlus", page = "Weekly Panel", section = "WEEKLY PANEL", highlight = "Show Weekly Panel" },
},
{
module = "Mythic+ Tools",
title = "Party Keystones",
desc = "A movable list of the group's keys, and who holds one for the dungeon you just entered",
nav = { module = "EllesmereUIMythicPlus", page = "Keystones", section = "PARTY KEYSTONES", highlight = "Show Party Keystones" },
},
},
},
{
version = "8.7.6",
-- No hero tier this patch: features are present, so this is not a
Expand Down Expand Up @@ -4108,6 +4148,7 @@ initFrame:SetScript("OnEvent", function(self)
EllesmereUIBlizzardSkin = "Clean and beautiful visual refreshes for Blizzard UI elements.",
EllesmereUIFriends = "A modern friends list with built-in organization tools.",
EllesmereUIMythicTimer = "A simple Mythic+ timer with full tracking customizations.",
EllesmereUIMythicPlus = "Dungeon scores, weekly runs, teleports and party keystones.",
EllesmereUIQuestTracker = "A clean, updated reskin of Blizzard's Quest Tracker.",
EllesmereUIMinimap = "A new age minimap with clean styling and square layout options.",
EllesmereUIDamageMeters = "Lightweight damage meters with simple but powerful customization.",
Expand Down Expand Up @@ -6541,6 +6582,7 @@ initFrame:SetScript("OnEvent", function(self)
EllesmereUIBlizzardSkin = "Clean and beautiful visual refreshes for Blizzard UI elements.",
EllesmereUIFriends = "A modern friends list with built-in organization tools.",
EllesmereUIMythicTimer = "A simple Mythic+ timer with full tracking customizations.",
EllesmereUIMythicPlus = "Dungeon scores, weekly runs, teleports and party keystones.",
EllesmereUIQuestTracker = "A clean, updated reskin of Blizzard's Quest Tracker.",
EllesmereUIMinimap = "A new age minimap with clean styling and square layout options.",
EllesmereUIDamageMeters = "Lightweight damage meters with simple but powerful customization.",
Expand Down
22 changes: 21 additions & 1 deletion EllesmereUI.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,7 +293,15 @@ local ICONS_PATH = MEDIA_PATH .. "icons\\"
-------------------------------------------------------------------------------
-- Season M+ Portals -- single source of truth for every portal/teleport
-- list in the suite (Chat sidebar flyout, Minimap flyout, QoL /keys name
-- resolver, DataBars travel tooltip). Update ONCE here each season.
-- resolver, QoL LFG teleport prompt, DataBars travel tooltip, Mythic+ Tools
-- abbreviations and teleports). Update ONCE here each season.
--
-- REPLACE the entries at a season rollover, never append: the two flyouts and
-- the travel tooltip render this list whole, so an early entry for next season
-- shows up as a dead portal button the moment it is committed. Consumers that
-- only look an entry up by dungeon name (QoL, Mythic+ Tools) are unaffected --
-- they intersect against C_ChallengeMode.GetMapTable() and so follow the
-- season over on their own.
-- spellID - primary teleport spell id
-- short - abbreviated label used by the flyout buttons
-- dungeonID - LFG dungeonID (GetLFGDungeonInfo name lookup)
Expand Down Expand Up @@ -328,6 +336,7 @@ local ADDON_ROSTER = {
{ folder = "EllesmereUIBlizzardSkin", display = "Blizz UI Enhanced", search_name = "EllesmereUI Blizz UI Enhanced", syncFolder = "EllesmereUIDragonRiding", syncDisplay = "Dragon Riding" },
{ folder = "EllesmereUIFriends", display = "Friends List", search_name = "EllesmereUI Friends List" },
{ folder = "EllesmereUIMythicTimer", display = "Mythic+ Timer", search_name = "EllesmereUI Mythic+ Timer" },
{ folder = "EllesmereUIMythicPlus", display = "Mythic+ Tools", search_name = "EllesmereUI Mythic Plus Tools" },
{ folder = "EllesmereUIQuestTracker", display = "Quest Tracker", search_name = "EllesmereUI Quest Tracker" },
{ folder = "EllesmereUIMinimap", display = "Minimap", search_name = "EllesmereUI Minimap" },
{ folder = "EllesmereUIChat", display = "Chat", search_name = "EllesmereUI Chat" },
Expand Down Expand Up @@ -377,6 +386,7 @@ EllesmereUI.ADDON_GROUPS = {
"EllesmereUIBlizzardSkin",
"EllesmereUIDamageMeters",
"EllesmereUIMythicTimer",
"EllesmereUIMythicPlus",
"EllesmereUIQuestTracker",
"EllesmereUIFriends",
"EllesmereUIMinimap",
Expand Down Expand Up @@ -943,6 +953,13 @@ EllesmereUI.RegisterSyncExclusions("EllesmereUIMythicTimer", {
"frameWidth",
})

-- The two keystone displays are placed through Unlock Mode, so their positions
-- stay per-profile on a mirror-group push, matching every other module.
EllesmereUI.RegisterSyncExclusions("EllesmereUIMythicPlus", {
"keystoneList.pos",
"centerBanner.pos",
})

-- Dragon Riding stores its HUD position in its own profile blob (unlockPos).
-- Keep each profile's placement when syncing, matching every other module.
EllesmereUI.RegisterSyncExclusions("EllesmereUIDragonRiding", {
Expand Down Expand Up @@ -1209,6 +1226,7 @@ do
EllesmereUICooldownManager = true,
EllesmereUIResourceBars = true,
EllesmereUIMythicTimer = true,
EllesmereUIMythicPlus = true,
EllesmereUIRaidFrames = true,
}
local hasWarning = WARN_MODULES[folder]
Expand Down Expand Up @@ -4137,6 +4155,7 @@ EllesmereUI._addonKeyToFolder = {
chat = "EllesmereUIChat",
questTracker = "EllesmereUIQuestTracker",
mythicTimer = "EllesmereUIMythicTimer",
mythicPlus = "EllesmereUIMythicPlus",
blizzardSkin = "EllesmereUIBlizzardSkin",
damageMeters = "EllesmereUIDamageMeters",
dataBars = "EllesmereUIDataBars",
Expand Down Expand Up @@ -10605,6 +10624,7 @@ function EllesmereUI:RegisterModule(folderName, config)
EllesmereUIResourceBars = true,
EllesmereUIUnitFrames = true,
EllesmereUIMythicTimer = true,
EllesmereUIMythicPlus = true,
-- v6.6 split
EllesmereUIQoL = true,
EllesmereUIBlizzardSkin = true,
Expand Down
Loading