Fix party ready check icon size and toggles ignoring party overrides - #1255
Open
dfrisone wants to merge 1 commit into
Open
Fix party ready check icon size and toggles ignoring party overrides#1255dfrisone wants to merge 1 commit into
dfrisone wants to merge 1 commit into
Conversation
UpdateReadyCheck resolved its settings straight from db.profile instead of the party/extra-aware proxy every other indicator updater uses. Because it re-sizes the shared ready-check texture on every paint, a party frame with an unsynced Indicators section was reset to the RAID icon size the moment the icon was drawn, so the party Icon Size slider had no visible effect even at max. Position was unaffected because AnchorReadyCheck already resolves the source live. Route the size and the Show Ready Check / Show Incoming Summon / Show Incoming Resurrection toggles through the same proxy, and fix the two status-text rez checks that gate on the same setting so the text hides for the frame whose icon actually shows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reported on 8.7.6: the Party Frames ready check Icon Size slider had no effect even at maximum.
Cause
UpdateReadyCheckreadreadyCheckSize,showReadyCheck,showSummonPendingandshowIncomingRezstraight fromdb.profile, while every sibling indicator updater resolves the party/extra-aware source:That function re-sizes the shared ready/summon/rez texture on every call, and it runs from the full paint pass plus
READY_CHECK,INCOMING_SUMMON_CHANGEDandINCOMING_RESURRECT_CHANGEDfor party buttons as well.ReloadPartyFramesapplied the correct party size and the next paint reset it to the raid value.Ready check position was unaffected because
AnchorReadyCheckalready resolves its source live viaLiveS(). One indicator reading two different settings sources is what made position work and size not.Only reproduces when the party Indicators section is set to custom (unsynced), since that is when a
party_readyCheckSizekey exists. With the section synced both paths read the same key, which is why it went unnoticed.Change
UpdateReadyCheckresolves the settings source through the same proxy chain as every other per-button updater, covering the size and the three visibility toggles.Notes
No behaviour change for raid frames:
readyCheckSizeis not inINDICATOR_SCALE_KEYS, so the proxy returns exactly whatdb.profilereturned. Party overrides only apply whenpartySyncSections.indicatorsis false and aparty_key is set, so existing profiles are untouched.No new events, no new frames, no secure-frame or combat-path changes.
Testing
luac -ppasses. Verified in game: with the party Indicators section set to custom, the party ready check icon now honours its own Icon Size through a full ready check, and raid frames are unchanged.