Secondary Stats Display: right-aligned values, row spacing, per-stat … - #1258
Closed
labrie75 wants to merge 1 commit into
Closed
Secondary Stats Display: right-aligned values, row spacing, per-stat …#1258labrie75 wants to merge 1 commit into
labrie75 wants to merge 1 commit into
Conversation
…colors
## What does this PR do?
Three readability improvements to the Secondary Stats overlay, all inside its
own section of `EllesmereUIQoL.lua`:
**Right-aligned values.** The overlay was a single left-justified FontString,
so each number started wherever its label happened to end and the column
wobbled. The text is now two FontStrings -- labels justified left, values
justified right -- sharing the same font, size and line spacing, so the rows
stay in step and the numbers line up on their right edge. Label widths vary a
lot between locales (compare the English and Korean screenshots), and the
value column absorbs all of it.
**Row spacing.** The lines sat directly on top of each other. Both columns now
get `SetSpacing(3)`, scaled together with the font size, so the block stays
readable at any overlay scale.
**Per-stat colors.** With no custom color picked, each secondary now has its
own hue -- Crit gold `ffd100`, Haste green `2ecc71`, Mastery blue `55aaff`,
Versatility violet `c77dff` -- and the value takes the row's color too, so each
stat reads as one piece. Tertiaries keep the original default, the player's
class color.
The existing options are unchanged: picking a custom secondary or tertiary
color still paints that whole group the chosen color exactly as before -- the
palette only applies while no custom color is set. Saved position, scale, the
tertiary toggle, and the secret-safe value path are untouched, and no new
locale keys are introduced (the labels reuse the existing `L("Crit")` family).
## How was it tested?
Tested in game on the 12.1 PTR with a koKR client: default palette with
tertiary rows enabled, and overlay rescaling. Values stay right-aligned as the
numbers change width, the row gap scales with the font, and tertiaries render
in the class color. No load errors.
## Screenshots
Same overlay on an English client (left) and a Korean client (right):
## Checklist
- [x] New settings default **OFF** -- n/a, no setting added
- [x] Zero cost while disabled -- the section still early-returns when the overlay is off
- [x] Cheap while enabled -- same update path; one extra FontString, built once
- [x] No writes onto Blizzard-owned frames -- the addon's own overlay frame only
- [x] Tested in-game, works on the 12.1 PTR; no load errors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…colors
What does this PR do?
Three readability improvements to the Secondary Stats overlay, all inside its own section of
EllesmereUIQoL.lua:Right-aligned values. The overlay was a single left-justified FontString, so each number started wherever its label happened to end and the column wobbled. The text is now two FontStrings -- labels justified left, values justified right -- sharing the same font, size and line spacing, so the rows stay in step and the numbers line up on their right edge. Label widths vary a lot between locales (compare the English and Korean screenshots), and the value column absorbs all of it.
Row spacing. The lines sat directly on top of each other. Both columns now get
SetSpacing(3), scaled together with the font size, so the block stays readable at any overlay scale.Per-stat colors. With no custom color picked, each secondary now has its own hue -- Crit gold
ffd100, Haste green2ecc71, Mastery blue55aaff, Versatility violetc77dff-- and the value takes the row's color too, so each stat reads as one piece. Tertiaries keep the original default, the player's class color.The existing options are unchanged: picking a custom secondary or tertiary color still paints that whole group the chosen color exactly as before -- the palette only applies while no custom color is set. Saved position, scale, the tertiary toggle, and the secret-safe value path are untouched, and no new locale keys are introduced (the labels reuse the existing
L("Crit")family).How was it tested?
Tested in game on the 12.1 PTR with a koKR client: default palette with tertiary rows enabled, and overlay rescaling. Values stay right-aligned as the numbers change width, the row gap scales with the font, and tertiaries render in the class color. No load errors.
Screenshots
Same overlay on an English client (left) and a Korean client (right):

Checklist