Skip to content

Fix party reload permanently writing overrides onto nil raid keys #1260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dfrisone wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −5
Open

Fix party reload permanently writing overrides onto nil raid keys #1260

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions EllesmereUIRaidFrames/EllesmereUIRaidFrames.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11343,12 +11343,16 @@ ns.ReloadPartyFrames = function()

-- Temp-swap: write party overrides onto db.profile so anchor closures
-- (which captured db.profile) read party values. Only for keys whose
-- section is custom (unsynced).
local saved = {}
-- section is custom (unsynced). `swapped` records WHICH keys were swapped:
-- a key whose raid value is nil (no default, never set on raid) stores
-- nothing in `saved`, so restoring from `saved` alone would skip it and
-- leave the party value on the shared raid key permanently.
local saved, swapped = {}, {}
for key, section in pairs(ns._PARTY_KEY_SECTION) do
if ns._IsPartySectionCustom(section) then
local pv = rawget(raw, "party_" .. key)
if pv ~= nil then
swapped[#swapped + 1] = key
saved[key] = raw[key]
raw[key] = pv
end
Expand Down Expand Up @@ -11504,9 +11508,10 @@ ns.ReloadPartyFrames = function()
end
end

-- Restore db.profile to raid values
for key, val in pairs(saved) do
raw[key] = val
-- Restore db.profile to raid values (via `swapped`, so a nil raid value
-- is written back as nil rather than skipped)
for _, key in ipairs(swapped) do
raw[key] = saved[key]
end

-- Re-layout header
Expand Down