Secondary Stats Display: right-aligned values, row spacing, per-stat colors - #1261
Open
labrie75 wants to merge 2 commits into
Open
Secondary Stats Display: right-aligned values, row spacing, per-stat colors#1261labrie75 wants to merge 2 commits into
labrie75 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Readability pass on the Secondary Stats overlay, plus a house-style color picker for it.
At a glance:
SetSpacing(3), scaled with the fontOverlay (
EllesmereUIQoL.lua)SetSpacing(3)between rows, scaled with the fontffd100/ Haste2ecc71/ Mastery55aaff/ Versc77dff,value colored with its label; tertiaries stay class-colored
Locale label widths differ a lot (see the two screenshots) -- the value column absorbs all of it.
Options (
EUI_QoL_Options.lua)multiswatchrow)Compatibility
How was it tested?
Tested in game on the 12.1 PTR with a koKR client: default palette with tertiary rows enabled,
overlay rescaling, and the swatch selectors (switching between Default / Class Color / Custom Color on the row and the tertiary pair in the cog, and picking a custom color, which flips its group to custom).
Values stay right-aligned as the numbers change width and the row gap scales with the font.
No load errors.
Screenshots
Same overlay on an English client (left) and a Korean client (right):
Checklist