Unit Frames: icon spacing for the Blizzard buff & debuff grid - #1264
Open
labrie75 wants to merge 4 commits into
Open
Unit Frames: icon spacing for the Blizzard buff & debuff grid#1264labrie75 wants to merge 4 commits into
labrie75 wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds icon spacing to the Blizzard Buffs & Debuffs grid, so the stock aura grid
can be tightened up (or spread out) the same way its icon size already can.
At a glance:
Layout (
EllesmereUIUnitFrames_PlayerAuras.lua)iconStride/addIconsToRight/addIconsToTop, so Edit Mode layouts are honoredUpdateGridLayouthooks the skin already installs (using the aura list Blizzard just laid out, so an aura applied this pass is spaced on the same frame), the coalesced refresh pass, andReloadFramesfor profile swapsOptions (
EUI_UnitFrames_Options.lua,EllesmereUIUnitFrames.lua)playerAurasalongside iconSize and the zoom values; a profile switch re-anchors immediatelyCompatibility
How was it tested?
Tested in game on live retail with a koKR client:
positive, zero and negative spacing on both buffs and debuffs, with icon size and icon zoom changed
alongside
auras applied and expiring in combat (including grids that wrap to several rows)
Edit Mode grid direction changes and profile switches between
profiles with different spacing. No errors, no per-frame work added.
Screenshots
Default (5 = Blizzard's own gap) and tightened:


Checklist