Add a "splice into" feature for Javascript/Typescript#10
Open
ishaqibrahimbot wants to merge 41 commits intoElonVolo:mainfrom
Open
Add a "splice into" feature for Javascript/Typescript#10ishaqibrahimbot wants to merge 41 commits intoElonVolo:mainfrom
ishaqibrahimbot wants to merge 41 commits intoElonVolo:mainfrom
Conversation
Previously, arg parser would display the arguments in the help section in alphabetical order. Since we're now moving in the direction of grouping arguments by functionality independent of names (like for upcoming --gitignore flag), we now have to come up with a quick refactoring that allows arguments to be displayed in a specified order regardless of what alphabetical order the arguments themselves occupy.
Remove dependency on argument name alphabetical order
Updating packages to latest versions
Implements facebook#456 md syntax highlighting
Adding js usage to the README using `Runner.run`
One of the code blocks was using tabs instead of spaces, which was inconsistent with the rest of the README.
Tabs to spaces in code examples for consistency
VSCode debugging setup docs
Majorly bumping version Bumping changelog. Again. alsdkfj alsdkfj
Due to the lack of maintenance on the upstream recast library, evcodeshift is switching to @coderaiser's excellently maintained @putout/recast fork. logitall unit tests were breaking due to a recast bug, and @putout/recast fixes it.
Switch to the @putout/recast fork
…tput Adding ability to save actual test output
Changed name of executable in README that was causing debugging not to work.
Fixing typo
Grammar corrections.
Fixing docs on programmatic use of API
ishaqibrahimbot
changed the title
Author
|
Hey @ElonVolo! I've made some good progress. There is now an To see it in action, follow these steps:
Note that Next up, I'll be adding some test cases to cover this functionality before wrapping up the PR. Let me know your thoughts and feedback! |
Author
|
Update: Have added 3 test cases under an 'edit' describe block in the cli tests file. Covered these scenarios:
This PR is now ready to be reviewed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Played around with the evcodeshift api and succeeded in creating a very minimal transformer. Next steps include making this more robust and complete, figuring out the proper file structure, adding the edit option to the cli, and writing tests.