Fix UX Refactor Sidebar component for improved layout and controls#66
Open
rajofearth wants to merge 3 commits into
Open
Fix UX Refactor Sidebar component for improved layout and controls#66rajofearth wants to merge 3 commits into
rajofearth wants to merge 3 commits into
Conversation
- Consolidate desktop sidebar controls into a single variable for better organization - Update SidebarHeaderNavigationControls to include drag region styling - Adjust rendering logic for settings button based on Electron environment
github-actions
Bot
added
size:M
vouch:unvouched
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
SidebarHeaderNavigationControlsto explicitly opt out of the Electron drag region so the navigation buttons and sidebar trigger remain reliably clickable.Why
The Electron sidebar/header flow had a few closely related control layouts split across different render paths, which made the structure harder to reason about and easier to drift out of sync. This change keeps the desktop controls centralized, improves maintainability, and makes the Electron-specific drag/click behavior more predictable.
The drag-region update is especially important in Electron because interactive controls inside draggable areas can become frustrating or unreliable if they are not explicitly marked as non-draggable. This keeps sidebar navigation behavior consistent while cleaning up the settings-view rendering logic.
UI Changes
Screen.Recording.2026-04-26.232619.mp4
Checklist