This repository was archived by the owner on Jun 1, 2026. It is now read-only.
qptr: add an immediate offset to Load/Store ops. #41
Closed
eddyb wants to merge 11 commits into
Closed
Conversation
ac8eafb to
231e84c
Compare
231e84c to
83ffe71
Compare
83ffe71 to
95f650c
Compare
bc53e10 to
a2cd69c
Compare
dd5857b to
74f388d
Compare
74f388d to
31942b4
Compare
31942b4 to
909f15a
Compare
d1f1f1f to
b03c9d6
Compare
b03c9d6 to
145051e
Compare
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While separate offseting works fine in general, having an immediate offset inside loads and stores (as this PR adds) can make the simplest case (i.e. no array indexing or buffers - especially local variables) easier.
There's two usecases that motivated this change:
qptr::lowersupport for [WIP] disaggregate by-valueOpTypeStruct/OpTypeArrayinputs/outputs. #29Op{Load,Store}would need to turn into NQPtrOp::{Load,Store}(one per aggregate leaf), and needing NQPtrOp::Offsets as well would be an annoying drawbackmem2reg+SROA, which specifically only propagates stores to loads, within local variables, and treats all other uses of the local variable base pointer as "escaping" (i.e. the contents of the variable can't be known anymore)TODO: changelog, maybe a comparison example (kinda hard tho).