Skip to content

Develop/nn#11

Merged
00lllooolll00 merged 6 commits into
masterfrom
develop/nn
Feb 25, 2026
Merged

Develop/nn#11
00lllooolll00 merged 6 commits into
masterfrom
develop/nn

Conversation

@00lllooolll00

Copy link
Copy Markdown
Collaborator

No description provided.

Copilot AI review requested due to automatic review settings February 24, 2026 05:16

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates core utilities and configuration in EmbeddedKit, primarily by centralizing common macros in ek_def.h and refactoring call sites to use them, along with small logging/assert cleanups and a config toggle change.

Changes:

  • Disable the shell module by default via EK_SHELL_ENABLE.
  • Refactor logging and assert helpers to use framework I/O and shared macros (ek_vsnprintf, EK_GET_FILE_NAME).
  • Introduce utility macros in ek_def.h and adopt EK_ARRAY_LEN in GPIO port drivers.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
ek_conf.h Changes default feature flag to disable shell module.
L2_Core/utils/src/ek_log.c Uses ek_vsnprintf and simplifies the color log prefix formatting.
L2_Core/utils/src/ek_assert.c Switches to shared EK_GET_FILE_NAME macro for cleaner assert logging.
L2_Core/utils/inc/ek_def.h Adds <stdarg.h>, introduces utility macros (EK_ARRAY_LEN, EK_CLAMP, EK_GET_FILE_NAME), and adds an unsupported-compiler hard error.
L2_Core/port/stm32f429zi/st_gpio_port.c Uses EK_ARRAY_LEN for GPIO table iteration.
L2_Core/port/gd32f470zgt6/gd_gpio_port.c Uses EK_ARRAY_LEN for GPIO table iteration.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread L2_Core/utils/inc/ek_def.h Outdated
Comment thread L2_Core/utils/inc/ek_def.h Outdated
00lllooolll00 and others added 2 commits February 25, 2026 18:06
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@00lllooolll00 00lllooolll00 merged commit f83526c into master Feb 25, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants