Develop/nn#12
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes hardcoded linker scripts and implements a dynamic linker script generation system. The system automatically generates appropriate linker scripts based on MCU-specific memory parameters, making the build configuration more maintainable and reducing code duplication across different MCU targets.
Changes:
- Introduced dynamic linker script generation mechanism with MCU-specific memory parameters
- Removed hardcoded linker scripts from build configuration files
- Removed unused CMSIS and STARM driver files
Reviewed changes
Copilot reviewed 57 out of 161 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| L1_MCU/STM32F429ZIT6_GCC/CMakeLists.txt | Added memory parameter definitions for linker script generation |
| L1_MCU/GD32F470ZGT6/CMakeLists.txt | Added memory parameter definitions for linker script generation |
| L1_MCU/CMakeLists.txt | Integrated linker script generation and configuration |
| CMakeLists.txt | Updated to use dynamically generated linker script |
| .github/workflows/build.yml | Removed hardcoded linker script path from build configuration |
| L1_MCU/STM32F429ZIT6_STARM/* | Deleted STARM MCU files and CMSIS drivers |
| L1_MCU/STM32F429ZIT6_GCC/stm32f429zit6_flash.ld | Removed static linker script file |
| L1_MCU/GD32F470ZGT6/gd32f470zgt6_flash.ld | Removed static linker script file |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.