Develop/nn#18
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a compile-time feature flag for the ek_evoke (event-driven scheduler) module so it can be cleanly enabled/disabled via ek_conf.h, and updates repository ignore rules to exclude Codex metadata.
Changes:
- Add
EK_EVOKE_ENABLEmodule switch inek_conf.h. - Gate
ek_evokeheader/source compilation onEK_USE_RTOS == 0 && EK_EVOKE_ENABLE == 1. - Ignore
.codexin.gitignore(and clarify the related comment).
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| L2_Core/utils/src/ek_evoke.c | Wrap implementation compilation with EK_EVOKE_ENABLE in addition to EK_USE_RTOS. |
| L2_Core/utils/inc/ek_evoke.h | Wrap API exposure with EK_EVOKE_ENABLE in addition to EK_USE_RTOS. |
| ek_conf.h | Define EK_EVOKE_ENABLE and document it in the module switches list. |
| .gitignore | Add .codex to ignored entries and adjust the header comment. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
16
to
20
| #include "ek_conf.h" | ||
|
|
||
| #if EK_USE_RTOS == 0 | ||
| #if EK_USE_RTOS == 0 && EK_EVOKE_ENABLE == 1 | ||
|
|
||
| # include "ek_def.h" |
There was a problem hiding this comment.
Header doc/@note currently states the module is available when EK_USE_RTOS == 0, but this header is now additionally gated by EK_EVOKE_ENABLE == 1. Please update the top-of-file notes (or add a new one) so the documentation matches the new compile-time condition.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.