Develop/nn#6
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes a large amount of STM32 MCU driver code and CMSIS (Cortex Microcontroller Software Interface Standard) files. The changes involve deleting entire directories of header files, source files, license documents, and build configuration files for the STM32F429ZIT6 MCU platform.
Changes:
- Deletion of CMSIS core and device-specific include files and license documentation
- Removal of STM32F4xx HAL driver source and header files for peripherals (USART, SPI, I2C, LTDC, DMA, FMC, GPIO, etc.)
- Removal of build configuration files (CMakeLists.txt, CMakePresets.json, .mxproject)
Reviewed changes
Copilot reviewed 50 out of 159 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| LICENSE.txt (CMSIS) | Removed Apache 2.0 license file for CMSIS |
| tz_context.h | Removed TrustZone context management header |
| pmu_armv8.h | Removed ARMv8 PMU API header |
| pac_armv81.h | Removed ARMv8.1-M PAC key functions header |
| mpu_armv8.h | Removed ARMv8/ARMv8.1-M MPU API header |
| mpu_armv7.h | Removed ARMv7-M MPU API header |
| cmsis_version.h | Removed CMSIS version definitions |
| cmsis_compiler.h | Removed CMSIS compiler abstraction header |
| cmsis_armcc.h | Removed CMSIS ARM Compiler 5 support |
| cachel1_armv7.h | Removed ARMv7 L1 cache API header |
| LICENSE.txt (STM32F4xx) | Removed STM32F4xx device license file |
| system_stm32f4xx.h | Removed STM32F4xx system header |
| stm32f4xx.h | Removed STM32F4xx main device header |
| Core/Src/*.c | Removed all peripheral initialization and system source files |
| Core/Inc/*.h | Removed all peripheral and system header files |
| CMakeLists.txt | Removed CMake build configuration |
| CMakePresets.json | Removed CMake preset configurations |
| .mxproject | Removed STM32CubeMX project metadata |
Comments suppressed due to low confidence (22)
L1_MCU/STM32F429ZIT6_GCC/Core/Src/usart.c:1
- The copyright year is set to 2026, which is in the future. This should be corrected to 2025 or an earlier year.
L1_MCU/STM32F429ZIT6_GCC/Core/Src/stm32f4xx_it.c:1 - The copyright year is set to 2026, which is in the future. This should be corrected to 2025 or an earlier year.
L1_MCU/STM32F429ZIT6_GCC/Core/Src/stm32f4xx_hal_timebase_tim.c:1 - The copyright year is set to 2026, which is in the future. This should be corrected to 2025 or an earlier year.
L1_MCU/STM32F429ZIT6_GCC/Core/Src/stm32f4xx_hal_msp.c:1 - The copyright year is set to 2026, which is in the future. This should be corrected to 2025 or an earlier year.
L1_MCU/STM32F429ZIT6_GCC/Core/Src/spi.c:1 - The copyright year is set to 2026, which is in the future. This should be corrected to 2025 or an earlier year.
L1_MCU/STM32F429ZIT6_GCC/Core/Src/main.c:1 - The copyright year is set to 2026, which is in the future. This should be corrected to 2025 or an earlier year.
L1_MCU/STM32F429ZIT6_GCC/Core/Src/ltdc.c:1 - The copyright year is set to 2026, which is in the future. This should be corrected to 2025 or an earlier year.
L1_MCU/STM32F429ZIT6_GCC/Core/Src/i2c.c:1 - The copyright year is set to 2026, which is in the future. This should be corrected to 2025 or an earlier year.
L1_MCU/STM32F429ZIT6_GCC/Core/Src/gpio.c:1 - The copyright year is set to 2026, which is in the future. This should be corrected to 2025 or an earlier year.
L1_MCU/STM32F429ZIT6_GCC/Core/Src/fmc.c:1 - The copyright year is set to 2026, which is in the future. This should be corrected to 2025 or an earlier year.
L1_MCU/STM32F429ZIT6_GCC/Core/Src/dma2d.c:1 - The copyright year is set to 2026, which is in the future. This should be corrected to 2025 or an earlier year.
L1_MCU/STM32F429ZIT6_GCC/Core/Src/dma.c:1 - The copyright year is set to 2026, which is in the future. This should be corrected to 2025 or an earlier year.
L1_MCU/STM32F429ZIT6_GCC/Core/Inc/usart.h:1 - The copyright year is set to 2026, which is in the future. This should be corrected to 2025 or an earlier year.
L1_MCU/STM32F429ZIT6_GCC/Core/Inc/stm32f4xx_it.h:1 - The copyright year is set to 2026, which is in the future. This should be corrected to 2025 or an earlier year.
L1_MCU/STM32F429ZIT6_GCC/Core/Inc/spi.h:1 - The copyright year is set to 2026, which is in the future. This should be corrected to 2025 or an earlier year.
L1_MCU/STM32F429ZIT6_GCC/Core/Inc/main.h:1 - The copyright year is set to 2026, which is in the future. This should be corrected to 2025 or an earlier year.
L1_MCU/STM32F429ZIT6_GCC/Core/Inc/ltdc.h:1 - The copyright year is set to 2026, which is in the future. This should be corrected to 2025 or an earlier year.
L1_MCU/STM32F429ZIT6_GCC/Core/Inc/i2c.h:1 - The copyright year is set to 2026, which is in the future. This should be corrected to 2025 or an earlier year.
L1_MCU/STM32F429ZIT6_GCC/Core/Inc/gpio.h:1 - The copyright year is set to 2026, which is in the future. This should be corrected to 2025 or an earlier year.
L1_MCU/STM32F429ZIT6_GCC/Core/Inc/fmc.h:1 - The copyright year is set to 2026, which is in the future. This should be corrected to 2025 or an earlier year.
L1_MCU/STM32F429ZIT6_GCC/Core/Inc/dma2d.h:1 - The copyright year is set to 2026, which is in the future. This should be corrected to 2025 or an earlier year.
L1_MCU/STM32F429ZIT6_GCC/Core/Inc/dma.h:1 - The copyright year is set to 2026, which is in the future. This should be corrected to 2025 or an earlier year.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.