tools: localhost: browser requests data - #124
Merged
Merged
Conversation
Switch the data updates from an unconditional 1Hz data send by the python server to a browser requested 1Hz poll model. This fixes two problems. If the browser suspends the tab due to inactivity, there is no longer a backlog of data to process when the user returns, as the requests were also suspended. The python server gets immediate notification when the browser disconnects, as it is handling events from the browser. Signed-off-by: Jordan Yates <jordan@embeint.com>
Extract websocket message generation to a dedicated function. Signed-off-by: Jordan Yates <jordan@embeint.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch the data updates from an unconditional 1Hz data send by the
python server to a browser requested 1Hz poll model. This fixes two
problems.
If the browser suspends the tab due to inactivity, there is no longer a
backlog of data to process when the user returns, as the requests were
also suspended.
The python server gets immediate notification when the browser
disconnects, as it is handling events from the browser.