tools: ota_upgrade: improvements - #163
Merged
Merged
Conversation
Include the key IDs in the information reported to the database when peeling through packets. This fixes the database rarely not knowing the devices network ID after a connection has been established, if both gateway and device are on the same network. Signed-off-by: Jordan Yates <jordan@embeint.com>
Use the response bytes object directly in a callback, instead of manually reconstructing it from a different argument. Signed-off-by: Jordan Yates <jordan@embeint.com>
Ensure that the local gateways and remote devices have synchronised times before starting the upgrade process. This ensures time isn't wasted by regenerating interface keys on each packet. Signed-off-by: Jordan Yates <jordan@embeint.com>
Unlike `run_file_upload`, the client timeout associated with `run_file_copy` needs to be large enough to contain the entire copy process, as the local gateway manages the copy itself. Signed-off-by: Jordan Yates <jordan@embeint.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure that the local gateways and remote devices have synchronised times before starting the upgrade process. This ensures time isn't wasted by regenerating interface keys on each packet.
Unlike
run_file_upload, the client timeout associated withrun_file_copyneeds to be large enough to contain the entire copy process, as the local gateway manages the copy itself.