Conversation
mmahsereci
approved these changes
Feb 21, 2026
Contributor
mmahsereci
left a comment
mmahsereci
left a comment
There was a problem hiding this comment.
Thanks, Andrei! Eyeballing this a bit as I have some trouble with my python installation atm but it looks good! Glad we can get rid of this extra dependency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: n/a
Description of changes: Noticed that scipy actually provides implementations of Sobol and Latin Hypercube designs. Meaning we can remove two dependencies! Plus a test to validate model free design's bounds.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.