Open
Conversation
Merged
rooooooooob
reviewed
Dec 25, 2021
Contributor
Author
|
I went ahead and also added a |
SebastienGllmt
commented
Dec 25, 2021
rooooooooob
reviewed
Dec 28, 2021
# Conflicts: # rust/pkg/cardano_serialization_lib.js.flow # rust/src/plutus.rs
zuzunker
reviewed
Feb 6, 2022
SebastienGllmt
force-pushed
the
witness-builder
branch
from
3def7b7 to
1c6beaa
Compare
# Conflicts: # rust/pkg/cardano_serialization_lib.js.flow # rust/src/lib.rs
# Conflicts: # rust/src/crypto.rs # rust/src/lib.rs # rust/src/plutus.rs # rust/src/utils.rs
|
This is important. Wen? |
|
Would it be possible to add functionality to combine two |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem with
TransactionWitnessSetis that at the protocol level it should be a set, but at the CDDL level it's just a list. This means it's up to individual implementations to de-duplication which is not ideal.This PR adds a TransactionWitnessSetBuilder which handles the deduplication for you. It's a first step to #37 and can also help with #273