fix: promote doctor proxy probe guidance#126
Open
dylan-isaac wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
@codex review Please review commit |
|
Codex Review: Didn't find any major issues. 👍 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gobbler doctor --json's top-level webpagefixCloses #125
Reproduction and root cause
With Crawl4AI
/healthhealthy but the configured proxy path failing/crawl, bothgobbler status --jsonandgobbler doctor --jsoncontained nested sanitized--no-proxyadvice. Status promoted that advice intoservices.webpage.fix; doctor hard-coded generic service/log guidance instead.A live maintainer smoke reproduced the mismatch. The corrected doctor report remains parseable and degraded, while its top-level
fixnow equalsconversion_probe.adviceand contains the safe direct-provider isolation command.Scope and non-goals
This changes only doctor summary selection for failed webpage conversion probes. Promotion requires both
suggested_command_fragmentandadvice; otherwise the generic fix remains. It does not change Crawl4AI probe generation, proxy detection, service health/readiness state, doctor exit semantics, JSON shape, or human output structure.Verification
uv sync --extra dev --extra docsuv run gobbler --version→ 0.2.33uv run pytest tests/unit/ -q --tb=short→ 770 passeduv run ruff format --check src/ tests/uv run ruff check src/ tests/uv run --extra docs mkdocs build --strictgit diff --checkReview
Round one Gate B primary correctness/scope review: PASS. Gate C hostile-input/security/privacy review: PASS. Gate C CI/reproducibility/release review: PASS. All reviewed immutable candidate
36cc521b6735f535f22a24de45ec237e94f6d6f1against base7976dc5557ed10c5becdb1db4fd31aa303539b57.Risk, docs, and version
Risk is limited to choosing the doctor report's top-level remediation string after a failed
/crawlprobe. Both changelogs, package/CLI/queue versions, browser-extension metadata, and static assertions are synchronized at 0.2.33. No README or command documentation change is needed because the command shape and JSON schema are unchanged.