Skip to content

fix: promote doctor proxy probe guidance#126

Open
dylan-isaac wants to merge 1 commit into
mainfrom
gobbler-loop-doctor-probe-guidance
Open

fix: promote doctor proxy probe guidance#126
dylan-isaac wants to merge 1 commit into
mainfrom
gobbler-loop-doctor-probe-guidance

Conversation

@dylan-isaac

Copy link
Copy Markdown
Contributor

Summary

  • promote actionable Crawl4AI conversion-probe advice into gobbler doctor --json's top-level webpage fix
  • keep generic service/log guidance when the probe does not provide a safe command fragment
  • add positive, negative, and credential-redaction regressions
  • release the bounded diagnostic fix as 0.2.33

Closes #125

Reproduction and root cause

With Crawl4AI /health healthy but the configured proxy path failing /crawl, both gobbler status --json and gobbler doctor --json contained nested sanitized --no-proxy advice. Status promoted that advice into services.webpage.fix; doctor hard-coded generic service/log guidance instead.

A live maintainer smoke reproduced the mismatch. The corrected doctor report remains parseable and degraded, while its top-level fix now equals conversion_probe.advice and contains the safe direct-provider isolation command.

Scope and non-goals

This changes only doctor summary selection for failed webpage conversion probes. Promotion requires both suggested_command_fragment and advice; otherwise the generic fix remains. It does not change Crawl4AI probe generation, proxy detection, service health/readiness state, doctor exit semantics, JSON shape, or human output structure.

Verification

  • red-first focused regression: actionable advice test failed against the hard-coded generic fix
  • fresh uv sync --extra dev --extra docs
  • uv run gobbler --version → 0.2.33
  • focused doctor/status/version/extension tests → 19 passed
  • uv run pytest tests/unit/ -q --tb=short → 770 passed
  • uv run ruff format --check src/ tests/
  • uv run ruff check src/ tests/
  • uv run --extra docs mkdocs build --strict
  • git diff --check
  • live doctor JSON smoke verified parseability, degraded readiness, and top-level/nested advice equality

Review

Round one Gate B primary correctness/scope review: PASS. Gate C hostile-input/security/privacy review: PASS. Gate C CI/reproducibility/release review: PASS. All reviewed immutable candidate 36cc521b6735f535f22a24de45ec237e94f6d6f1 against base 7976dc5557ed10c5becdb1db4fd31aa303539b57.

Risk, docs, and version

Risk is limited to choosing the doctor report's top-level remediation string after a failed /crawl probe. Both changelogs, package/CLI/queue versions, browser-extension metadata, and static assertions are synchronized at 0.2.33. No README or command documentation change is needed because the command shape and JSON schema are unchanged.

@dylan-isaac

Copy link
Copy Markdown
Contributor Author

@codex review

Please review commit 36cc521b6735f535f22a24de45ec237e94f6d6f1 against base 7976dc5557ed10c5becdb1db4fd31aa303539b57.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 👍

Reviewed commit: 36cc521b67

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Doctor JSON hides actionable Crawl4AI proxy probe guidance

1 participant