Fix style tag accumulation when loading dialogs#179
Merged
EndoHizumi merged 5 commits intomainfrom Mar 22, 2026
Merged
Conversation
Co-authored-by: EndoHizumi <5486808+EndoHizumi@users.noreply.github.com>
Co-authored-by: EndoHizumi <5486808+EndoHizumi@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix issue of proliferating style tags
Fix style tag accumulation when loading dialogs
Dec 22, 2025
EndoHizumi
requested changes
Mar 22, 2026
Owner
EndoHizumi
left a comment
There was a problem hiding this comment.
@copilot ダイアログ表示時に古いスタイルが残ってるので、修正をお願いします。
Co-authored-by: EndoHizumi <5486808+EndoHizumi@users.noreply.github.com> Agent-Logs-Url: https://github.com/EndoHizumi/webTaleKit/sessions/a2bf2795-d1ae-4666-9c20-6a7d7f86b958
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Style tags were accumulating in
document.headeach time a dialog was loaded, causing the style sheet to grow indefinitely.Root Cause
In
loadScreen(), old style tags were removed only for regular scenes, but new style tags were always appended regardless of whether it was a dialog or regular scene:This caused dialog styles to accumulate, and dialogs also need their own styles to render properly.
Changes
For regular scenes (
!isDialog):For dialogs (
isDialog):data-dialog-styleattribute)data-dialog-style="true"markerOriginal prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.