Refactor type definitions into separate files by EndoHizumi · Pull Request #33 · EndoHizumi/webTaleKit

EndoHizumi · 2025-06-10T09:38:57Z

Extract interfaces from index.ts into organized type definition files by domain, improving code modularity and maintainability. Clean up duplicate entries in tsconfig.json.

- Create organized type definition files in src/types/ - Separate interfaces by domain: config, scenario, resource, api - Update index.ts to import interfaces from modular files - Clean up tsconfig.json duplicate entries 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>

Copilot

Pull Request Overview

This PR refactors type definitions by extracting interfaces from index.ts into domain-specific files and removing duplicate entries from tsconfig.json to improve modularity and maintainability.

Extracted scenario, resource, config, and API type definitions to separate files.
Organized type exports via index.ts to simplify module imports.

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
src/types/scenario.ts	New type definitions for various scenario-related objects
src/types/resource.ts	Defined interfaces for image and sound resources
src/types/index.ts	Aggregates exports from the type definition files
src/types/config.ts	Introduces engine and scene configuration interfaces
src/types/api.ts	Declares command list interface and related API types

Comments suppressed due to low confidence (3)

src/types/scenario.ts:14

The property 'get' in ScenarioObject might be too ambiguous given that it overlaps with HTTP methods and could be confused with accessor methods. Consider renaming it to something more descriptive such as 'httpGet'.

  get?: string;

src/types/resource.ts:2

The import path for SoundObject uses 'soundObject' which may be inconsistent with typical PascalCase naming conventions for files. Confirm that the file naming is intentional or update it to 'SoundObject' to match convention.

import { SoundObject } from '../resource/soundObject';

src/types/api.ts:26

Using the reserved word 'if' as a property name in the CommandList interface could be confusing. Consider renaming it (e.g., 'ifCommand' or 'conditional') to enhance clarity.

  if: (scenarioObject: IfHandlerScenario) => Promise<void>;

…-core

EndoHizumi · 2025-07-19T05:27:48Z

型定義が合っているのが、あやしくなってきたので、いちど、確認し直す。

Copilot

Pull request overview

Copilot reviewed 6 out of 7 changed files in this pull request and generated 13 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-03T16:47:50Z

src/core/index.ts

+  jumpHandler(line: JumpHandlerScenario): void {
+    outputLog('call:', 'debug', line.index);
+    // ジャンプ先が現在の行より小さいときは、今の行とジャンプ先の行の間で、sub=falseの行を抽出して、scenarioManagerに追加する
+    if (line.index! < this.scenarioManager.getIndex()) {


The non-null assertion operator is unnecessary here since line.index is already defined as a required property (not optional) in the JumpHandlerScenario interface. Remove the ! operator.

Suggested change

if (line.index! < this.scenarioManager.getIndex()) {

if (line.index < this.scenarioManager.getIndex()) {

Copilot · 2026-01-03T16:47:50Z

src/core/index.ts

+    outputLog('call', 'debug', line);
+    const isTrue = this.executeCode(`return ${line.condition}`);
+    outputLog(`${isTrue}`, 'debug');
+    const appendScenario = isTrue ? line.content![0].content : line.content![1].content;


The non-null assertion operator is unnecessary here since line.content is defined as a required property (not optional) in the IfHandlerScenario interface. Remove the ! operator.

Suggested change

const appendScenario = isTrue ? line.content![0].content : line.content![1].content;

const appendScenario = isTrue ? line.content[0].content : line.content[1].content;

Copilot · 2026-01-03T16:47:51Z

src/core/index.ts

+  // Sceneファイルに、ビルド時に実行処理を追加して、そこに処理をお願いしたほうがいいかも？
+  callHandler(line: CallHandlerScenario): void {
+    outputLog('call', 'debug', line);
+    this.executeCode(line.method!);


The non-null assertion operator is unnecessary here since line.method is defined as a required property (not optional) in the CallHandlerScenario interface. Remove the ! operator.

Suggested change

this.executeCode(line.method!);

this.executeCode(line.method);

Copilot · 2026-01-03T16:47:51Z

src/core/index.ts

+    const headers = line.content!
+      .filter((content: any) => content.type === 'header')[0]
+      .content.reduce(
+        (acc: any, header: any) => ({
+          ...acc,
+          [header.type]: header.content,
+        }),
+        {},
+      );


Potential runtime error: The code assumes the filter will always find an element with type === 'header', but if it doesn't exist, accessing [0] will be undefined, causing .content.reduce to throw an error. Add a check to ensure the filtered result has at least one element before accessing it.

Copilot · 2026-01-03T16:47:51Z

src/core/index.ts

+    const headers = line.content!
+      .filter((content: any) => content.type === 'header')[0]
+      .content.reduce(
+        (acc: any, header: any) => ({
+          ...acc,
+          [header.type]: header.content,
+        }),
+        {},
+      );
+    const body = line.content!
+      .filter((content: any) => content.type === 'data')[0]
+      .content.reduce(
+        (acc: any, header: any) => ({
+          ...acc,
+          [header.type]: header.content,
+        }),
+        {},
+      );


Potential runtime error: The code assumes the filter will always find an element with type === 'data', but if it doesn't exist, accessing [0] will be undefined, causing .content.reduce to throw an error. Add a check to ensure the filtered result has at least one element before accessing it.

Suggested change

const headers = line.content!

.filter((content: any) => content.type === 'header')[0]

.content.reduce(

(acc: any, header: any) => ({

...acc,

[header.type]: header.content,

}),

{},

);

const body = line.content!

.filter((content: any) => content.type === 'data')[0]

.content.reduce(

(acc: any, header: any) => ({

...acc,

[header.type]: header.content,

}),

{},

);

const headerContent = line.content

?.filter((content: any) => content.type === 'header')[0];

const headers = headerContent && Array.isArray(headerContent.content)

? headerContent.content.reduce(

(acc: any, header: any) => ({

...acc,

[header.type]: header.content,

}),

{},

)

: {};

const dataContent = line.content

?.filter((content: any) => content.type === 'data')[0];

const body = dataContent && Array.isArray(dataContent.content)

? dataContent.content.reduce(

(acc: any, header: any) => ({

...acc,

[header.type]: header.content,

}),

{},

)

: {};

Copilot · 2026-01-03T16:47:52Z

src/core/index.ts

+    const key = line.name!;
+    outputLog('moveToHandler:displayedImages', 'debug', this.displayedImages);
+    await this.drawer.moveTo(key, this.displayedImages, { x: line.x!, y: line.y! }, line.duration || 1);


The non-null assertion operators are unnecessary here since line.name, line.x, and line.y are all defined as required properties (not optional) in the MoveToHandlerScenario interface. Remove the ! operators.

Suggested change

const key = line.name!;

outputLog('moveToHandler:displayedImages', 'debug', this.displayedImages);

await this.drawer.moveTo(key, this.displayedImages, { x: line.x!, y: line.y! }, line.duration || 1);

const key = line.name;

outputLog('moveToHandler:displayedImages', 'debug', this.displayedImages);

await this.drawer.moveTo(key, this.displayedImages, { x: line.x, y: line.y }, line.duration || 1);

Copilot · 2026-01-03T16:47:53Z

src/core/index.ts

+      line.then = line.content!.filter((content: any) => content.type === 'then')[0].content;
+    } else {
+      const json = await response.json();
+      this.sceneFile.res = json;
+      line.error = line.content!.filter((content: any) => content.type === 'error')[0].content;


Potential runtime error: The code assumes the filter will always find an element with type === 'then', but if it doesn't exist, accessing [0] will be undefined, causing .content to throw an error. Add a check to ensure the filtered result has at least one element before accessing it.

Suggested change

line.then = line.content!.filter((content: any) => content.type === 'then')[0].content;

} else {

const json = await response.json();

this.sceneFile.res = json;

line.error = line.content!.filter((content: any) => content.type === 'error')[0].content;

const thenContent = line.content?.find((content: any) => content.type === 'then');

if (thenContent && thenContent.content) {

line.then = thenContent.content;

}

} else {

const json = await response.json();

this.sceneFile.res = json;

const errorContent = line.content?.find((content: any) => content.type === 'error');

if (errorContent && errorContent.content) {

line.error = errorContent.content;

}

Copilot · 2026-01-03T16:47:53Z

src/core/index.ts

+  CallHandlerScenario,
+  HttpHandlerScenario
+} from '../types/scenario'


Unused import HttpHandlerScenario.

Suggested change

CallHandlerScenario,

HttpHandlerScenario

} from '../types/scenario'

CallHandlerScenario

} from '../types/scenario'

Copilot · 2026-01-03T16:47:53Z

src/core/index.ts

+    line.content?.forEach((choice: any) => {
+      choice.label = this.expandVariable(choice.label);
+    });
+    const { selectId, onSelect: selectHandler }: ChoiceResult = await this.drawer.drawChoices(line as any);


Unused variable selectId.

Suggested change

const { selectId, onSelect: selectHandler }: ChoiceResult = await this.drawer.drawChoices(line as any);

const { onSelect: selectHandler }: ChoiceResult = await this.drawer.drawChoices(line as any);

Copilot · 2026-01-03T16:47:53Z

src/core/index.ts

+    // ScenarioManagerの初期化（変数の初期値設定）
+    this.scenarioManager = new ScenarioManager();
+    // ResourceManagerの初期化（引数にconfigを渡して、リソース管理配列を作る）
+    this.resourceManager = new ResourceManager(import(/* webpackIgnore: true */ '/src/resource/config.js')); //  webpackIgnoreでバンドルを無視する


Superfluous argument passed to constructor of class ResourceManager.

Suggested change

this.resourceManager = new ResourceManager(import(/* webpackIgnore: true */ '/src/resource/config.js')); // webpackIgnoreでバンドルを無視する

this.resourceManager = new ResourceManager(); // webpackIgnoreでバンドルを無視する

EndoHizumi requested a review from Copilot June 10, 2025 09:39

EndoHizumi self-assigned this Jun 10, 2025

Copilot AI reviewed Jun 10, 2025

View reviewed changes

Merge remote-tracking branch 'origin/develop' into feature/replace-ts…

a8b0178

…-core

EndoHizumi requested a review from Copilot January 3, 2026 16:44

Copilot started reviewing on behalf of EndoHizumi January 3, 2026 16:45 View session

Copilot AI reviewed Jan 3, 2026

View reviewed changes

	if (line.index! < this.scenarioManager.getIndex()) {
	if (line.index < this.scenarioManager.getIndex()) {

	const appendScenario = isTrue ? line.content![0].content : line.content![1].content;
	const appendScenario = isTrue ? line.content[0].content : line.content[1].content;

	this.executeCode(line.method!);
	this.executeCode(line.method);

	const { selectId, onSelect: selectHandler }: ChoiceResult = await this.drawer.drawChoices(line as any);
	const { onSelect: selectHandler }: ChoiceResult = await this.drawer.drawChoices(line as any);

	this.resourceManager = new ResourceManager(import(/* webpackIgnore: true */ '/src/resource/config.js')); // webpackIgnoreでバンドルを無視する
	this.resourceManager = new ResourceManager(); // webpackIgnoreでバンドルを無視する

Conversation

EndoHizumi commented Jun 10, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

EndoHizumi commented Jul 19, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Jan 3, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 3, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 3, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 3, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 3, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 3, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 3, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 3, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 3, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 3, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants