Skip to content

Fix unhandled promise rejection in #clearReady() #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Claude wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Fix unhandled promise rejection in #clearReady() #37

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1b845cc
Initial plan
Claude Feb 27, 2026
eb85549
Fix unhandled promise rejection in #clearReady()
Claude Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,6 +195,8 @@ export default class PushReceiver extends Emitter<ClientEvents> {

#clearReady() {
if (!this.#ready.isResolved) {
// Attach a catch handler to prevent unhandled rejection warning
this.#ready.promise.catch(() => {})
this.#ready.reject(new Error('Client destroyed'))
Comment on lines 197 to 200
Copy link

Copilot AI Feb 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if (!this.#ready.isResolved) is not doing what it suggests: defer() currently returns isResolved as a snapshot boolean, so it never updates when resolve/reject are called (see src/utils/defer.ts). As a result, #clearReady() will always enter this block and attempt to reject, even after the promise was already settled. Consider changing defer() to expose a live flag (e.g., a getter) or updating this check so it accurately reflects the promise state.

Suggested change
if (!this.#ready.isResolved) {
// Attach a catch handler to prevent unhandled rejection warning
this.#ready.promise.catch(() => {})
this.#ready.reject(new Error('Client destroyed'))
// Attach a catch handler to prevent unhandled rejection warning
this.#ready.promise.catch(() => {})
// Safely attempt to reject the current ready promise, even if it may
// already be settled. Wrap in try/catch in case the underlying
// implementation throws when rejecting a settled promise.
try {
this.#ready.reject(new Error('Client destroyed'))
} catch {
// Ignore errors from rejecting an already-settled promise

Copilot uses AI. Check for mistakes.
}

Expand Down