Fix and modification of "download_file"#63
Open
solanav wants to merge 2 commits intoEnterpriseyIntranet:masterfrom
Open
Fix and modification of "download_file"#63solanav wants to merge 2 commits intoEnterpriseyIntranet:masterfrom
solanav wants to merge 2 commits intoEnterpriseyIntranet:masterfrom
Conversation
Filenames are URL-encoded, so we should preserve the original filename when saving them.
|
The inspection completed: 1 new issues, 1 updated code elements |
|
( If you still have the test case, i ll be grateful if you test with my repo — refactored code and python2 compat — : https://github.com/luffah/nextcloud-API ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was an error when downloading text files on
f.write(res.data)in webdav.py:I also added a two new parameters to this function: