Suggestion for fix of issue about CPUs with 128 threads#47
Open
zubankov wants to merge 2 commits intoEntityFX:masterfrom
Open
Suggestion for fix of issue about CPUs with 128 threads#47zubankov wants to merge 2 commits intoEntityFX:masterfrom
zubankov wants to merge 2 commits intoEntityFX:masterfrom
Conversation
Author
|
It may be necessary to increase limit more for further processors with 256 threads, which will be available in the near future? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It should fix issue #46 #46 , as I tested on our 2 CPUs Loongson 3C6000/D with total 128 threads.
I'm not sure if these are all the changes that are needed, because I additionally applied changes to make it works (due to small amount of time on this CPUs) :
From https://github.com/EntityFX/anybench/blob/master/src/benchmarks/generic/mpmflops/mpmflops.c#L184 to:
if (threads > 200) threads = 64;From https://github.com/EntityFX/anybench/blob/master/src/benchmarks/generic/mpmflops/mpmflops.c#L202 to:
if (param01 == 0) threads = 64;