fix(core): validate wrapped external workspace configs#1068
Merged
Conversation
Deploying agentv with
|
| Latest commit: |
01c1a41
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://202055e7.agentv.pages.dev |
| Branch Preview URL: | https://fix-external-workspace-confi.agentv.pages.dev |
christso
commented
Apr 13, 2026
Collaborator
Author
christso
left a comment
christso
left a comment
There was a problem hiding this comment.
Minor nit: return resolvedWorkspace on line 767 (after the throw block) is always undefined at that point since the truthy case already returned. Should be return undefined; for clarity — there's no scenario where the variable is needed there.
return undefined;
The return after the wrapped-workspace throw block always holds undefined since the truthy case already returned. Use an explicit return undefined for clarity. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1067
Summary
workspace:keyVerification
bun test packages/core/test/evaluation/workspace-config-parsing.test.tsgit push: