docs: clarify env var fallback for eval interpolation#928
Merged
Conversation
Deploying agentv with
|
| Latest commit: |
54b0e17
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0bd95836.agentv.pages.dev |
| Branch Preview URL: | https://fix-927-env-fallback-docs.agentv.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
${{ VAR_NAME }}resolution reads exported process environment variables directly.envfiles are optional and only augment the environment when present.envfileCloses #927.
Red
Issue #927 described
.envas required in CI. That matched the docs wording before this PR:targets/configuration.mdxsaid${{ VARIABLE_NAME }}reads values "from your .env file"quickstart.mdxinstructed users to define target env names in.envGreen
Verified on current
origin/mainand this branch that no.envfile is required for interpolation:CI_TEMPLATE_PATH=/tmp/template bun -e "import { loadTestSuite } from './packages/core/src/evaluation/yaml-parser.ts'; const suite = await loadTestSuite(process.argv[1], process.cwd()); console.log(suite.tests[0].workspace?.template);" /tmp/env-path.eval.yamlThis resolved
workspace.templateto the exported path directly.Verification
bun test packages/core/test/evaluation/interpolation-integration.test.tsloadTestSuite()resolved${{ CI_TEMPLATE_PATH }}with no.envpresent